Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#6424 closed enhancement (fixed)

Add additional class to sitewide notices table element

Reported by: hnla Owned by: DJPaul
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

For some reason we have the same class messages-notices on both messages table loop & notices table loop messages-loop.php & notices-loop.php.

This causes issues trying to target the two screens and table displays without having to break out of the nested scss ruleset flow i.e #buddypress{table {} }

Preferable would be to remove messages-notices from the general user messages loop but this might have issues if styles have been built on this class; so alternative is add sitewide-notices to the notices loop class.

Patch adds this class to style on.

Attachments (1)

6424.01.patch (738 bytes) - added by hnla 5 years ago.

Download all attachments as: .zip

Change History (5)

@hnla
5 years ago

#1 @r-a-y
5 years ago

Yeah, I noticed this as well when I was looking at the twentyfifteen companion stylesheet and preparing some enhancements.

I'm okay with this going in.

#2 @DJPaul
5 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

#3 @djpaul
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 9863:

Templates: add new CSS class to Notices loop wrapper.

This lets themes target the Notices loop specifically. Previously, you could only use a selector that matches both the Messages and Notices loop.

Fixes #6424, props hnla

#4 @DJPaul
3 years ago

  • Component changed from Appearance to Templates
Note: See TracTickets for help on using tickets.