Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#6423 closed enhancement (fixed)

Add new message class to buddypress.css

Reported by: hnla Owned by: hnla
Milestone: 2.3 Priority: normal
Severity: minor Version:
Component: Templates Keywords: has-patch commit
Cc:

Description

Currently BP offers these following main styled classes for messages:

  • Info
  • Updated
  • Error

Proposal is to add one further class ‘warning’ to complete the set as it were so we have:

  • general 'info'
  • success/updated
  • error (it’s gone wrong!)
  • warning – (Be careful here, a note of caution)

Currently Imaths avatar project uses the class ‘warning’ this would be better moved into general BP styles keeping the avatar.css for it’s necessary rules/properties it needs to function rather than mixing in visual flourishes.

Patch adds new class in same manner as existing ones.

As this is under #buddypress namespace and as themes won't have used this class it should present no problems.

Attachments (1)

6423.01.patch (528 bytes) - added by hnla 4 years ago.
Warning class.

Download all attachments as: .zip

Change History (6)

@hnla
4 years ago

Warning class.

#2 @DJPaul
4 years ago

Where would this new class be used? Nowhere yet, right?

#3 @DJPaul
4 years ago

  • Keywords commit added

@hnla Go ahead and commit this if you want it in 2.3. I haven't checked how well the colour looks with relation to the other success/warning colours in context (all of the existing colour choices appear a bit dubious, but...), I'll trust that you and imath think it ok.

#4 @hnla
4 years ago

  • Owner set to hnla
  • Resolution set to fixed
  • Status changed from new to closed

In 9865:

Add additional message class to BP styles

Commit adds a new ruleset to style '#messages.warning' this matches to the existing .error, .updated, .info classes and completes a set.

Colors chosen to as closely match and compliment the existing classes.

See #6423 Close #6423

#5 @DJPaul
3 years ago

  • Component changed from Appearance to Templates
Note: See TracTickets for help on using tickets.