Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 3 years ago

#6412 closed defect (bug) (fixed)

Community moderators do not see "Messages" menu for displayed members

Reported by: johnjamesjacoby Owned by:
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Messages Keywords: good-first-bug 2nd-opinion has-patch needs-unit-tests
Cc:

Description (last modified by johnjamesjacoby)

When logged in as a user with the bp-moderate cap, and when viewing a member other than yourself, the main navigation of most other components is visible, but Messages is strangely absent.

Attachments (2)

6412.diff (15.1 KB) - added by pareshradadiya 4 years ago.
Proposed fix
6412.2.diff (16.3 KB) - added by pareshradadiya 4 years ago.
Bulk action fix

Download all attachments as: .zip

Change History (11)

#1 @johnjamesjacoby
4 years ago

I think we have two options:

  • Use bp_core_can_edit_settings() instead of false for the show_for_displayed_user setting. This brings it up to par with Notifications, Settings, etc...
  • Set Notifications and Settings to false so no one, not even super-admins, can see the menu items. Note that visibility does not dictate availability, and capable super-admins can still visit those pages.

Bigger picture, we could introduce a "moderation mode" for members that would override these settings. I'm imagining an experience where no user can ever edit any other user until they've re-authenticated with a password, and that super-ability is maybe time-limited or tied to a specific piece of session data.

Last edited 4 years ago by johnjamesjacoby (previous) (diff)

#2 @johnjamesjacoby
4 years ago

  • Description modified (diff)

#3 @johnjamesjacoby
4 years ago

  • Summary changed from Super admins do not see "Messages" menu for displayed users to Community moderators do not see "Messages" menu for displayed members

@pareshradadiya
4 years ago

Proposed fix

#4 @pareshradadiya
4 years ago

  • Keywords has-patch added

#5 @imath
4 years ago

  • Keywords needs-unit-tests added

pareshradadiya thanks a lot for your patch, it would be awesome to have unit tests to be sure everything is ok :)

@pareshradadiya
4 years ago

Bulk action fix

#6 @johnjamesjacoby
4 years ago

In 9934:

Messages: Use bp_core_can_edit_settings() to ensure navigation is visible to capable administrators

This change brings Messages up to par with all other member components, making sure it's navigation is visible even for displayed users to capable community administrators.

See #6412.

#7 @DJPaul
4 years ago

Where are we with this? Is @pareshradadiya's patch still required?

#8 @DJPaul
4 years ago

  • Milestone changed from 2.4 to Future Release

Moved to future release awaiting feedback from JJJ

#9 @DJPaul
3 years ago

  • Milestone changed from Future Release to 2.4
  • Resolution set to fixed
  • Status changed from new to closed

I think this was done.

Note: See TracTickets for help on using tickets.