Community moderators do not see "Messages" menu for displayed members

[johnjamesjacoby]

When logged in as a user with the bp-moderate cap, and when viewing a member other than yourself, the main navigation of most other components is visible, but Messages is strangely absent.

[johnjamesjacoby]

I think we have two options:

• Use bp_core_can_edit_settings() instead of false for the show_for_displayed_user setting. This brings it up to par with Notifications, Settings, etc...
• Set Notifications and Settings to false so no one, not even super-admins, can see the menu items. Note that visibility does not dictate availability, and capable super-admins can still visit those pages.

Bigger picture, we could introduce a "moderation mode" for members that would override these settings. I'm imagining an experience where no user can ever edit any other user until they've re-authenticated with a password, and that super-ability is maybe time-limited or tied to a specific piece of session data.

[pareshradadiya]

Proposed fix

[imath]

pareshradadiya thanks a lot for your patch, it would be awesome to have unit tests to be sure everything is ok :)

[pareshradadiya]

Bulk action fix

[johnjamesjacoby]

In 9934:

Messages: Use bp_core_can_edit_settings() to ensure navigation is visible to capable administrators

This change brings Messages up to par with all other member components, making sure it's navigation is visible even for displayed users to capable community administrators.

See #6412.

[DJPaul]

Where are we with this? Is @pareshradadiya's patch still required?

[DJPaul]

Moved to future release awaiting feedback from JJJ

[DJPaul]

I think this was done.