#6380 closed enhancement (fixed)
Grunt needs to convert SCSS -> CSS
Reported by: | DJPaul | Owned by: | djpaul |
---|---|---|---|
Milestone: | 2.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch early |
Cc: |
Description
Grunt has a SCSS linter, but doesn't convert the file to CSS.
I thought it did, so this was an oversight on my part when we started comitting #6291.
Attachments (1)
Change History (8)
#2
@
9 years ago
@netweb I think you said you were working on something like this, but hnla and I needed something quickly, so happy to hear any considered suggestions you might have.
#3
@
9 years ago
Yeah, I did, yours is basically the same, for context it was in Slack here:
The compile .scss to .css task is "nearly done" -> https://cloudup.com/cwB9SXoNrMy
That said, it looks fine what you added, I'd suggest not naming the subtask admin
, in bbPress this is named like so as we use SASS for our admin/MP6 themes, I think styles
would be a better name for BuddyPress' current usage, and with the possibly that @tw2113 "wants" a BP MP6 theme it also leaves that door open.
#4
@
9 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
The change in 6380.1.diff from admin
to styles
is required as part of the proposed Grunt watch task in #6382 :)
In 9768: