Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#6380 closed enhancement (fixed)

Grunt needs to convert SCSS -> CSS

Reported by: DJPaul Owned by: djpaul
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch early
Cc:

Description

Grunt has a SCSS linter, but doesn't convert the file to CSS.

I thought it did, so this was an oversight on my part when we started comitting #6291.

Attachments (1)

6380.1.diff (283 bytes) - added by netweb 4 years ago.
Minor change to Grunt SCSS sub task name

Download all attachments as: .zip

Change History (8)

#1 @djpaul
4 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 9768:

Grunt: add tooling to convert SCSS to CSS files.

Fixes #6380

#2 @DJPaul
4 years ago

@netweb I think you said you were working on something like this, but hnla and I needed something quickly, so happy to hear any considered suggestions you might have.

#3 @netweb
4 years ago

Yeah, I did, yours is basically the same, for context it was in Slack here:

The compile .scss to .css task is "nearly done" -> https://cloudup.com/cwB9SXoNrMy

That said, it looks fine what you added, I'd suggest not naming the subtask admin, in bbPress this is named like so as we use SASS for our admin/MP6 themes, I think styles would be a better name for BuddyPress' current usage, and with the possibly that @tw2113 "wants" a BP MP6 theme it also leaves that door open.

@netweb
4 years ago

Minor change to Grunt SCSS sub task name

#4 @netweb
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The change in 6380.1.diff from admin to styles is required as part of the proposed Grunt watch task in #6382 :)

#5 @DJPaul
4 years ago

  • Keywords has-patch early added
  • Milestone changed from 2.3 to 2.4

#6 @djpaul
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 10230:

Build: rename Grunt sass admin task to sass styles

We SASS everything in the bp-legacy folder, so “styles” is a better
name for it. Also brings in line with sister project bbPress.

Fixes #6380

Props netweb

#7 @DJPaul
3 years ago

  • Component changed from Tools - Build Process to Build/Test Tools
Note: See TracTickets for help on using tickets.