Skip to:
Content

Opened 3 years ago

Closed 3 years ago

Last modified 19 months ago

#6291 closed enhancement (fixed)

Companion stylesheet task - twentyfifteen

Reported by: hnla Owned by: hnla
Milestone: 2.3 Priority: high
Severity: minor Version:
Component: Templates Keywords: has-patch commit
Cc:

Description

This ticket manages the Twentyfifteen companion stylesheet specific task.

Style discussions and all patches for the task will be maintained here.

Technical discussions pertaining to the general Companion Stylesheet requirements will be kept to #6248

To load these sheets in a development environment you will need to patch buddypress-functions.php with the following patch:

https://buddypress.trac.wordpress.org/raw-attachment/ticket/6124/6124.01.patch
Zip - https://buddypress.trac.wordpress.org/attachment/ticket/6124/6124.01.patch

Initial style file patch provides a scss file and compiled dev css sheet - these files will be iterated on as '-01', '-02' etc

The initial patch files set out a basic sectioned layout to follow and guidelines for working with media queries and other aspects of the parent theme.

The initial patch for this task (2015) includes a series of provisional starter styles that further address some issues with BP styles as seen under twentyfifteen and also starts to look at structural elements with a view to re-factoring them to better suit unique BP generated content.

Attachments (21)

twentyfifteen-comp-style.patch (13.4 KB) - added by hnla 3 years ago.
Initial sass/css files
bp-2015-default-wp-page.jpg (139.1 KB) - added by hnla 3 years ago.
2015 default page/post
bp-2015-widescreen-up.jpg (75.0 KB) - added by hnla 3 years ago.
Re-factored content area widescreen up
bp-2015-tablet-landscape.jpg (75.0 KB) - added by hnla 3 years ago.
Re-factored content tablet landscape medium up
bp-2015-small-screen-tablet-portrait.jpg (34.9 KB) - added by hnla 3 years ago.
Re-factored small screen content
bp-2015-user-nav.png (139.1 KB) - added by hnla 3 years ago.
twentyfifteen-comp-style.02.patch (26.9 KB) - added by hnla 3 years ago.
Latest revision of core scss file, with essential style corrections.
twentyfifteen-comp-style.03.patch (27.7 KB) - added by hnla 3 years ago.
update file for formatting.
twentyfifteen-comp-style.04.patch (27.8 KB) - added by hnla 3 years ago.
further formatting updates
twentyfifteen-comp-style.05.patch (14.4 KB) - added by netweb 3 years ago.
twentyfifteen-comp-style.06.patch (24.9 KB) - added by hnla 3 years ago.
Further formatting - ammend sectional comment structure.
twentyfifteen-comp-style.07.patch (32.5 KB) - added by hnla 3 years ago.
Update sheet with basic color variable decs. Update BP lists formatting.
twentyfifteen-comp-style.08.patch (32.4 KB) - added by hnla 3 years ago.
Correct format errors.
twentyfifteen-comp-style.09.patch (32.5 KB) - added by hnla 3 years ago.
format corrections
twentyfifteen-comp-style.10.patch (37.6 KB) - added by hnla 3 years ago.
Updated BP list styling & general styles
twentyfifteen-comp-style.11.patch (38.6 KB) - added by hnla 3 years ago.
Update User item-header elements layout
twentyfifteen-comp-style.12.patch (40.7 KB) - added by hnla 3 years ago.
Update general user account screens
twentyfifteen-comp-style.13.patch (8.3 KB) - added by hnla 3 years ago.
Address Single Groups - item-header responsive breakpoint layout, ibasic pass to style item-body content screens, update navigation to mirror user account vert nav style.
twentyfifteen-comp-style.14.patch (10.1 KB) - added by hnla 3 years ago.
Update .13 patch to remove Avatar sub nav tabbed styles -moved to avatar.css
6291.ray.patch (7.4 KB) - added by r-a-y 3 years ago.
6291.notices.patch (1.4 KB) - added by r-a-y 3 years ago.

Download all attachments as: .zip

Change History (68)

#1 @johnjamesjacoby
3 years ago

  • Owner set to hnla
  • Status changed from new to assigned

#2 @johnjamesjacoby
3 years ago

  • Keywords needs-patch added
  • Priority changed from normal to high
  • Severity changed from normal to minor

@hnla
3 years ago

Initial sass/css files

#3 @hnla
3 years ago

Initial Patch provides the structure for rulesets along with basic comment guide to suggested use, breakpoint examples, font-sizing mixin.

In addition the initial sheet further builds on the corrective styles first implemented for BP/twentyfifteen display, adjusting some aspects such as form input controls widths and table cell widths.

This initial patch should be iterated on as '-01', '02' etc.

#4 @hnla
3 years ago

  • Keywords has-patch added; needs-patch removed

Main Structural Elements of twentyfifteen theme and BP Screens.

2015 has a layout style that designed to best display content in a post/blog specific manner with fairly narrow content areas.

BP screens such as single members user accounts are screens that render quite a bit of detailed content and in some sense represent a utility aspect of a site.

I am going to suggest that with themes such as 2015 / 2014 we take the view that BP screens are handled separately and re-factor those default content widths; so The posts pages have one distinct look but when we hit a BP screen we update that look to show off the BP screens in their own right.

The SC below are rough examples of this in practise where we widen the 'article' dimensions and massage the margins and padding.

Against 2015 breakpoints we:

  • Widen content and reduce right margin for wide screen & up, preserving the max width and left margin.
  • On tablet landscape or approx 960 to 760 we remove the margins and maximise our real estate for '.post'.
  • On small screens tablet portrait we preserve the look but reduce the margins to squeeze a little more real estate (this view I'm not sure about adjusting as its less obvious a change and thus might look odd jumping between bp-user & posts/pages)
  • On all screens medium up we lose the top margin and padding to bring the post content section 'up' while padding down the heading to line up with site title.

In the initial sass file I have added a section to manage primary layout elements along with a very basic set of rulesets under breakpoints to demonstrate controlling the dimensions/margins/padding of elements such as the page article, this would need building on though and is a suggestion with example as a discussion point.

Last edited 3 years ago by hnla (previous) (diff)

@hnla
3 years ago

2015 default page/post

@hnla
3 years ago

Re-factored content area widescreen up

@hnla
3 years ago

Re-factored content tablet landscape medium up

@hnla
3 years ago

Re-factored small screen content

#5 @rosyteddy
3 years ago

How does the Activity / Profile page looks like with 10 or more Profile Menu items on a small mobile screen? Any screenshot ? Does extra menu items get collapsed under a "More" dropdown ?

Thanks

#6 @hnla
3 years ago

@roseteddy We haven't really got to this level of detail yet, but item-list-tabs in a horizontal view are always an issue where they are dynamic in nature and allow for additional items of unspecified number, vertical navigation is preferable really. If you have any ideas for approaches to take we would love to see them.

#7 @rosyteddy
3 years ago

Not "unspecified number" but just the default items in default profile menu perhaps with addition of a Media and Event tab. Code for this seem to be already there (if we do not want to reinvent wheel) - please see the profile menu items in regular and browser collapsed to minimum view here http://demo.buddyboss.com/boss/members/guest/

Maybe they can "give back" to community just the code for this Profile menu tabs / items without hampering their business model.

Next version of WP will again ship with another theme - so why do we need to think and design for Twenty-Fifteen. It wastes time and energy. Priority is elsewhere - Lets have a responsive theme like Buddyboss or Kleo for BP that will always ship with BP as a standard. This does not mean BP compatibility with all other WP themes will be in conflict. As of now BP is "operable" in any of the current WP themes. So that is fine and let it be like that.

BP has its own "needs" so a BP specific-need-addressing theme is needed that also take template parts like this https://buddypress.trac.wordpress.org/ticket/6296 into consideration.

Thanks a lot and best regards

#8 @hnla
3 years ago

so why do we need to think and design for Twenty-Fifteen.

The principle point in this exercise as originally conceived was to have a mechanism to apply additional styling to themes that we could know about and that were always ready by default to be activated along with BP i.e the WP twenty* themes, this was in large prompted by some less than ideal rendering of BP elements under twentyfifteen, having agreed we would tackle that it was considered an opportunity to actually ensure that BP under these default themes showcased as well as possible.

This exercise doesn't preclude a more specialised theme at some future point and indeed we have the basics of that in the Template Pack that was started a while back.

Last edited 3 years ago by hnla (previous) (diff)

#9 @hnla
3 years ago

BP nav menus / item-list-tabs

RFC:

Below are SC showing a basic implementation of the user object nav in a vertical configuration and a more common horizontal one.

The focus here is for comment on which layout is preferred, vertical or horizontal style.

At small screen sizes, mobile/small tablet portrait, the menus will collapse to a default li element vertical alignment regardless of vert or hori approaches later on. Medium tablet landscape and up can accommodate either a vertical arrangement or a horizontal one.

Opinions sought for one way over the other - styling wise is less the concern here, implemented are some styles to allow the menus items to move from simple text links to something a little more identifiable as a menu, comments or thoughts though on styles that might work or indeed other examples will be most appreciated.

@hnla
3 years ago

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


3 years ago

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


3 years ago

@hnla
3 years ago

Latest revision of core scss file, with essential style corrections.

#12 @hnla
3 years ago

If we want to get an early file commit underway we can start with the last patch here to facilitate ease of contribution, this patch does contain a compiled css file though and not sure how that's to be handled, but seemed best to have been including those for these initial patches. If/ when someone has a moment free to review and commit @jjj @boonebgorges @DJPaul

This ticket was mentioned in Slack in #buddypress by boone. View the logs.


3 years ago

@hnla
3 years ago

update file for formatting.

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


3 years ago

#15 @DJPaul
3 years ago

Copying netweb's recent comments from Slack here so they aren't lost:

Bit more feedback on the latest patch twentyfifteen-comp-style.03.patch in #6291

* There is still some trailing whitespace at the end of lines
* Tabbed indentation is still off in some places
* Lines #182-183, #193, #489-498: commented out code should not be included, if it is there for a "future" iteration then add a comment explaining the reason it remains commented out
* Comments should be formatted per https://make.wordpress.org/core/handbook/coding-standards/css/#commenting
* Common spacing between parentheses, various instances of both `(something)` and `( something )`, the later is what they all should be
* Files should have a blank new line at the end of the file 

@hnla
3 years ago

further formatting updates

@hnla
3 years ago

Further formatting - ammend sectional comment structure.

#16 @DJPaul
3 years ago

  • Keywords commit added

#17 @henry.wright
3 years ago

Not sure if you've already addressed this but when you output more action buttons to items in the members loop using the bp_directory_members_actions action, a vertical scroll bar appears if there isn't enough space. See the screenshot below for an example of what happens.

http://i.imgur.com/sN4OPkw.jpg

I think the same applies to the group members loop.

#18 @hnla
3 years ago

@henry.wright is that a patched view? Those action buttons had been absolutely positioned and fixed height causing misery, in the updated styles I've had to try re-factoring the buttons completely and for various device displays so should work better and not get lost off screen, it's an aspect though that will probably need refining.

#19 @henry.wright
3 years ago

Sorry @hnla, the screenshot isn't using any of this ticket's patches or commits. It's taken from a plain ol' 2.2.1 install.

If I had to guess what's causing the vert scroll bar, I'd say overflow-y: scroll has been applied somewhere.

@hnla
3 years ago

Update sheet with basic color variable decs. Update BP lists formatting.

@hnla
3 years ago

Correct format errors.

#20 @DJPaul
3 years ago

Relevant commits that adjust the SCSS linting rules: r9746, r9747.

These properties are questionable and hnla and I decided that we need to investigate them to see if they are beneficial rules that we want to adopt/reinstate.

@hnla
3 years ago

format corrections

#21 @hnla
3 years ago

In 9748:

Initial commit for scss stylesheet to support the Companion styles task for twentyfifteen theme.

Companion Styles are intended to support the default BP styles and enhance BP displayed with the standard WP themes and ensure BP is presented at it's best.

Provides the initial file format and baseline corrective styles along with breakpoint responsive layout and new user account menu layout.

An SCSS linter was previously added to Grunt in r9697.

See #6291
Props mercime, jjj, djpaul

#22 @djpaul
3 years ago

In 9749:

Add RTL CSS for the twentyfifteen companion stylesheet.

See #6291 and r9748.

#23 @hnla
3 years ago

Updated patch - Styles for further refinements to:

  • All primary lists, with a focus on screen width element layout
  • Activity stream entries and comment styling
  • General styles to bring into line more with parent theme.

@hnla
3 years ago

Updated BP list styling & general styles

@hnla
3 years ago

Update User item-header elements layout

@hnla
3 years ago

Update general user account screens

#24 @hnla
3 years ago

Commit added @ r9767 (hnla forget keyword 'see' :( )

#25 @djpaul
3 years ago

In 9769:

Update CSS for the twentyfifteen companion stylesheet.

See #6291

#26 @netweb
3 years ago

Related: #6381

#27 @hnla
3 years ago

In 9770:

Commit formatting corrections for 2015 companion styles.

  • Addresses extraneous missed trailing white space
  • Leading zeros on values
  • Remove tab indented blank lines

See #6381
See #6291
Props netweb

@hnla
3 years ago

Address Single Groups - item-header responsive breakpoint layout, ibasic pass to style item-body content screens, update navigation to mirror user account vert nav style.

@hnla
3 years ago

Update .13 patch to remove Avatar sub nav tabbed styles -moved to avatar.css

#28 @hnla
3 years ago

In 9806:

Commit updates twentyfifteen companion style files

  • Adds border-radius mixins
  • Update Sections / section numbering
  • Addresses single group screens styling headers for responsive breakpoints
  • Item-body component styling, settings sub screens
  • Removes Avatar upload nav tabbed styles from twentyfifteen to avatar.css to provide tabbed styles theme independent.

See #6291

#29 @hnla
3 years ago

In 9807:

Update twentyfifteen companion styles
Commit adds:

  • Updated & improved sectioning for user & group screens, clearer ordering of item-header & item-body for global and individual screens
  • Adds mixin to manage messages.notices boxes for color/border
  • Adds additional color variables
  • Corrects display issues,user screens
  • Updates what's new area
  • Adds tabbed nav style for profile edit group names
  • Updates styles for profile

See #6291

#30 @hnla
3 years ago

In 9852:

Updates to twentyfifteen companion styles.
General updates for user account screens:

  • Messaging, Compose, Notices props imath for noting autocomplete formatting
  • Settings screens - port styles from 2014 sheet & modify

Update general tables for TH header backgrounds.
Update messages / notices port mixin from 2014 sheet plus color variables.
check, adjust thread star.
updates to what's new posting, using new activity class.
See #6291

#31 @imath
3 years ago

Just noticed some inconsistency in Sites directory comparing it with Groups directory or Members directory for the twentyfifteen theme.

In these directories, the search box is over the main navigation. In the sites directory it's on the right of it but at the same level :

https://farm9.staticflickr.com/8876/17235458318_cdffbbe1f0_o.png

#32 @hnla
3 years ago

@imath
hmm, thanks good spot. The reason this is happening is we have inconsistent template which is really bad -all directory index templates should be identical, the 'sites' one has the form element opening div right after #buddpress, whereas on the others it comes just before the item-list-tabs with the dir search and 'bp_before' do_actions before it so the form acts as the natural break I need.

Was going to suggest I would need to add some hacky unnecessary rules just to fix Sites dir but then realised in reality the template must be corrected to match others as it's outputting a nested set of forms the current way it exists.

#33 @r-a-y
3 years ago

Been testing the companion stylesheet over the last day and you've done some really great work with responsiveness, hnla!

I've made a few adjustments in ray.patch.

  • Added some spacing where appropriate to let things breathe a bit more.
  • Some responsive tweaks for the item header on single pages.
  • Changed the object-nav and sub-nav to use the serif font that twentyfifteen uses. This is to emulate how twentyfifteen uses the serif font on gray backgrounds.
  • Removed zebra-striping for the message box and message thread screens. Zebra-striping is passé.

Lastly, I have completely altered the message box layout. I found that the amount of data being displayed in the table row was very tight and constricting (especially on smaller screens), so I've made things resemble more of a forum thread.

See screenshot:
http://i.imgur.com/iTrmYl0.png

The CSS for the layout uses calc(), which works all the way down to IE9. For the "View Message" text, that uses the attr() from the link title. This also works down to IE9.

Pick and choose the mods you want to include :)

I'm not tied to the message box layout so feel free to discard. Interested to hear what others think about it.

Last edited 3 years ago by r-a-y (previous) (diff)

@r-a-y
3 years ago

#34 @hnla
3 years ago

@r-a-y Message box layout is excellent, that is just the sort of forward thinking we need on elements like this - alternative approaches to visually rendering, I'm with you on the previous/existing standard table cell layout being cramped - does this work for all screen sizes, an issue though is the way the th bulk select checkbox cell stretches across, maybe given the room there it could have a bit of :after {content: "select all";}

My only reservation would the use of 'calc' unless it's now airtight with all browsers implementing fully with no partials/bugs.

Spacing I'm fine with if you think it needed it, there were and are areas that would take a further pass and adjustment.

I'm ok with removing zebra striping but not sure I would go as far as saying it's passé that smacks of designery notions, striping was a means of easing things on the eyes when looking at long sets of rows, I wasn't enamoured of what I had done though, but don't want to see that dirty yellow background that's crept back in ;) :)

Cool on the font, actually in twentyfourteen I added a simple mixin for font-family for this purpose but hadn't ported that across ( working between two sheets one forgets to bring over useful things sometimes) so will port that mixin and adjust, but good call, we do want elements to either 'inherit' parent styles or state them to override BP set ones.

I'll patch this a bit later and have a close look, thanks, oh and I'll badger on slack to get people to comment on message layout.

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.


3 years ago

#36 @hnla
3 years ago

I'm going to pull the font-family change on the object/subnavs as looking at twentyfifteen the use of their 'noto sans' is mainly reserved for their various subtext and meta type entries, with the navigational elements using their serif font so will leave BP navs inheriting the serif but have added both fonts to sheet as it makes sense to try and run through our meta entries and ensure they use the sans font.

#37 @hnla
3 years ago

In 9859:

Update twentyfifteen companion styles
commit adds:
Additions provided by r-a-y for message thread layout, single headers, spacing, fonts.
Various style updates and scss additions.

  • Re-factor message thread layout - cheers r-a-y.
  • Add default fonts mixins
  • Port over updated vendor prefix mixin scss-lint disable rules block.
  • Update small screen responsive view for activity stream items.
  • Provide minor styling for activity-permalink views.
  • Updates single-item screens header responsive styles - cheers r-a-y.

See #6291 Props r-a-y

#38 @hnla
3 years ago

In 9861:

Updates to Twentyfourteen & Twentyfifteen scss files
General updates for both files to ensure uniform message notice elements rulesets; adjust colors.
update user item action buttons for small screens Twentyfourteen.
See #6338 See #6291

#39 @hnla
3 years ago

In 9866:

Update twentyfifteen companion styles

  • Update messages mixin for conditional variables to match twentyfourteen
  • Update messages rulesets.

_ Adjust responsive styling for group members list.

See #6291

#40 @r-a-y
3 years ago

Here's a patch to format the Messages > Notices page a bit better.

Screenshot:
http://i.imgur.com/im9HVqw.png

The "Delete Message" link uses content:attr(), which works down to IE9. Looks good all the way down to IE8 as well.

@r-a-y
3 years ago

#41 @hnla
3 years ago

@r-a-y Thanks, this complements the inbox screen display so I'll patch and commit this shortly. What I did miss is we inherited the styles from the inbox re-factor, now we have the additional class for the notices screen table that was missing, it might be worth checking if we can reduce the selector sets specificy for these two screens working from just the common classes and individual ones.

#42 @hnla
3 years ago

In 9867:

Update twentyfifteen companion styles Notices table

Update styles the sitewide notices table list to match to the inbox message threads list visual display.

See #6291 Props r-a-y

#43 @hnla
3 years ago

In 9871:

Update twentyfifteen companion styles - scss corrections, breakpoint adjustments

  • Reduce whats-new selector grouping specificity. Remove .active class, js patch punted to 2.4.
  • Update small screen whats-new-options elements and reverse the ordering of options select and submit controls.
  • Re-factor scss CSS section commenting to correct compiling error seeing comments as rules and extracting & grouping separated from their nested rulesets.

See #6291

#44 @hnla
3 years ago

In 9875:

Updates to twentyfifteen companion styles

  • Adjust margins/padding act comment forms
  • Adjust table td width notifications table
  • Minor nested selector updates

See #6291

#45 @hnla
3 years ago

In 9876:

Updates & corrections to twentyfifteen companion styles

  • Remove styles on message options.
  • Mirror group manage settings styles on group create settings elements.
  • Add group create classes to form overrides.
  • Add margin spacing for item-body messages instances.


See #6291

#46 @johnjamesjacoby
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

#47 @DJPaul
19 months ago

  • Component changed from Appearance to Templates
Note: See TracTickets for help on using tickets.