Changeset 9697

Timestamp:

04/05/2015 02:21:26 PM (10 years ago)

Author:

djpaul

Message:

Build: add SCSS linter (grunt-scss-lint) to Grunt build process.

As part of the companion stylesheet changes for BP 2.3 (#6291 #6338), we'll be adding SCSS files to src/bp-templates/bp-legacy/css/ to help modernise our CSS workflow. This change adds a SCSS linter to help us maintain our code quality.

An empty src/bp-templates/bp-legacy/css/twentyfifteen.scss file has been added because the linter hangs if you tell it to run in a folder that does not contain any SCSS files. This will be replaced shortly with the real companion stylesheet for twentyfifteen (#6291).

As grunt-scss-lint relies on a ruby gem, the Travis-CI config has been modified to install it before running tests.

Fixes #6351, props netweb.

Location:

trunk

Files:

• .scss-lint.yml (added)
• .travis.yml (modified) (1 diff)
• Gruntfile.js (modified) (2 diffs)
• package.json (modified) (1 diff)
• src/bp-templates/bp-legacy/css/twentyfifteen.scss (added)

trunk/.travis.yml

@@ -56 +56 @@
     - cd $plugin_dir
     - npm install -g grunt-cli
+    - gem install scss-lint
 
 # before_script: Failures in this section will result in build status 'errored'

trunk/Gruntfile.js

@@ -164 +164 @@
             }
         },
+        scsslint: {
+            options: {
+                bundleExec: false,
+                colorizeOutput: true,
+                config: '.scss-lint.yml'
+            },
+            core: [ SOURCE_DIR + 'bp-templates/bp-legacy/css/*.scss' ]
+        },
         cssmin: {
             minify: {
@@ -229 +237 @@
      * Register tasks.
      */
-    grunt.registerTask( 'src',     ['jsvalidate:src', 'jshint', 'cssjanus'] );
+    grunt.registerTask( 'src',     ['jsvalidate:src', 'jshint', 'scsslint', 'cssjanus'] );
     grunt.registerTask( 'commit',  ['src', 'checktextdomain', 'imagemin'] );
     grunt.registerTask( 'build',   ['commit', 'clean:all', 'copy:files', 'uglify', 'jsvalidate:build', 'cssmin', 'makepot', 'exec:bpdefault'] );

trunk/package.json

@@ -21 +21 @@
     "grunt-patch-wordpress": "~0.3.0",
     "grunt-sass": "~0.18.0",
+    "grunt-scss-lint": "~0.3.6",
     "grunt-wp-i18n": "~0.5.0",
     "matchdep": "~0.3.0"