No 'type' property in BP_Core_Members_Template

[henry.wright]

In the constructor for BP_Core_Members_Template, I'm seeing $type being assigned to a property: $this->type = $type

But I don't see where the type property is declared in that class? The class doesn't extend another class either.

A forum member has mentioned they are having problems with the sort order. See:

​https://buddypress.org/support/topic/only-one-result-for-certain-types-in-members-loop/

[boonebgorges]

$type is the first variable passed to the constructor. See ​https://buddypress.trac.wordpress.org/browser/trunk/src/bp-members/bp-members-template.php#L546. Are you seeing PHP notices or anything like that?

[henry.wright]

Yep, it's passed to the constructor and then in the constructor it's assigned to a property. For example: $this->type = $type. But shouldn't that property be defined in the class definition? Something like:

class BP_Core_Members_Template {

    public $type;

    // etc...
}

It doesn't seem to be in this case. Not sure if that would cause issues?

[boonebgorges]

Ah, I see - sorry for not understanding before. Not having it defined in the class definition shouldn't cause any technical problems, but the documentation should be provided in any case.

[boonebgorges]

In 9563:

Add documentation for BP_Core_Members_Template::$type property.

Props henry.wright.
Fixes #6262.

[henry.wright]

Regarding the docblock summary "The type of member being requested. Used for ordering results", is it worth making it clearer that the attribute is nothing to do with the new member type feature? Because this particular attribute is more to do with the sort order, 'active', 'random', 'newest', 'popular'.

[boonebgorges]

Replying to henry.wright:

Regarding the docblock summary "The type of member being requested. Used for ordering results", is it worth making it clearer that the attribute is nothing to do with the new member type feature? Because this particular attribute is more to do with the sort order, 'active', 'random', 'newest', 'popular'.

I feel like the documentation to BP_Core_Members_Template::__construct() and especially BP_User_Query makes this point pretty clear. But if you have a suggestion for wording, feel free to write up a patch and reopen this ticket.

[henry.wright]

Ok no problem. It's probably just me. When I first read it, for some reason I thought of the new member type feature, and it threw me for a few seconds.