Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#6228 closed defect (bug) (fixed)

Pass $this instances to loop_start and loop_end actions in Members and Invites template.

Reported by: tw2113's profile tw2113 Owned by: boonebgorges's profile boonebgorges
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Groups Keywords: needs-patch
Cc:

Description

We have duplicate hook names that don't have a way to differentiate what is being affected at the given time.

Boone suggested at ​https://buddypress.trac.wordpress.org/ticket/5943#comment:11 that we pass the $this instance into each, which can be used to determine which loop_start or loop_end is being affected.

See #5943 for more details on the hooks documenting that surfaced the detail.

Attachments (1)

bp-groups-template-6228.diff​ (1.9 KB) - added by tw2113 10 years ago.

Download all attachments as: .zip

Change History (4)

@tw2113
10 years ago

#1 @johnjamesjacoby
10 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.3

Looks great.

#2 @boonebgorges
10 years ago

  • Keywords needs-patch added; has-patch commit removed

If we're going to do it here, can we do it in all our template classes across components?

#3 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9706:

Pass template object to 'loop_start' and 'loop_end' actions in groups template classes.

Props tw2113.
Fixes #6228.

Note: See TracTickets for help on using tickets.