Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#5943 closed enhancement (fixed)

BP Groups Hooks Documentation

Reported by: tw2113 Owned by:
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Core Keywords:
Cc:

Description

This ticket will be where all BP Groups patches go for the Hooks Documentation.

Relevant files:
bp-groups-actions.php
bp-groups-activity.php
bp-groups-admin.php
bp-groups-adminbar.php
bp-groups-cache.php
bp-groups-classes.php
bp-groups-filters.php
bp-groups-forums.php
bp-groups-functions.php
bp-groups-loader.php
bp-groups-notifications.php
bp-groups-screens.php
bp-groups-template.php
bp-groups-widgets.php

Change History (29)

#1 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Type changed from enhancement to task

Moving into Future Release; we can keep these here and move them into particular releases' milestones as we commit things (or work on them).

#2 @tw2113
5 years ago

Not sure how we want to handle the following:

add_meta_box(
	$screen['slug'],
	$screen['name'],
	create_function( '', 'do_action( "bp_groups_admin_meta_box_content_' . $this->slug . '", ' . $group_id . ' );' ),
	get_current_screen()->id,
	$screen['metabox_context'],
	$screen['metabox_priority']
);

#3 @tw2113
5 years ago

In 9450:

Adds hooks documentation to bp-groups-activity.

See #5943.

#4 @tw2113
5 years ago

In 9451:

Adds hooks documentation to bp-groups-actions.php.

See #5943.

#5 @tw2113
5 years ago

In 9452:

Adds and fixes hooks documentation for bp-groups-filters.php.

See #5943.

#6 @tw2113
5 years ago

In 9453:

Adds hooks documentation to bp-groups-widgets.php.

See #5943.

#7 @tw2113
5 years ago

In 9454:

Adds hooks documentation to bp-groups-loader.php.

See #5943.

#8 follow-up: @tw2113
5 years ago

We have a small case of duplicate action hook names with no direct way to differentiate between the two. The hook is "loop_end" in bp-groups-template.php and is used for both the Members and the Invites methods.

Thoughts on how to handle this? Pass in a string indicating which is being associated at that moment? Graceful renaming of one or both of them?

Last edited 5 years ago by tw2113 (previous) (diff)

#9 @tw2113
5 years ago

While we're in this file, we have the same situation with loop_start for both Members and Invites.

This ticket was mentioned in Slack in #buddypress by tw2113. View the logs.


5 years ago

#11 in reply to: ↑ 8 @boonebgorges
5 years ago

Replying to tw2113:

We have a small case of duplicate action hook names with no direct way to differentiate between the two. The hook is "loop_end" in bp-groups-template.php and is used for both the Members and the Invites methods.

Thoughts on how to handle this? Pass in a string indicating which is being associated at that moment? Graceful renaming of one or both of them?

We can't rename them. It would be fine to pass an additional parameter - $this would make the most sense, as the loop type can be inferred from the template object. Let's do this as part of a separate ticket, please, as it's not directly related to documentation.

#12 @tw2113
5 years ago

In 9487:

Adds hooks documentation to bp-groups-admin.php.

See #5943

#13 @tw2113
5 years ago

In 9488:

Adds hooks documentation for bp-groups-forums.php.

See #5943.

#14 @tw2113
5 years ago

In 9489:

Adds hooks documentation to bp-groups-notifications.php.

See #5943.

#15 @tw2113
5 years ago

In 9490:

Adds hooks documentation for bp-groups-functions.php.

See #5943.

#16 @tw2113
5 years ago

In 9491:

Adds hooks documentation to class-bp-groups-member.php.

See #5943.

#17 @tw2113
5 years ago

In 9492:

Adds hooks documentation to class-bp-groups-member-suggestions.php.

See #5943.

#18 @tw2113
5 years ago

In 9493:

Adds hooks documentation to class-bp-groups-group.php.

See #5943.

#19 @tw2113
5 years ago

In 9494:

Adds hoks documentation to class-bp-group-member-query.php.

See #5943.

#20 @tw2113
5 years ago

In 9495:

Adds hooks documentation to class-bp-grou-extension.php.

See #5943

#21 @tw2113
5 years ago

In 9496:

Fix typo in @param for phpdoc.

See #5943.

#22 @tw2113
5 years ago

In 9511:

Adds hooks documentation for bp-groups-screens.php.

See #5943.

#23 @tw2113
5 years ago

In 9512:

Adds hooks documentation to bp-groups-template.php.

See #5943.

#24 @tw2113
5 years ago

In 9541:

Updates filter docs for changes made in #9535.

See #5943.

#25 @tw2113
4 years ago

  • Milestone changed from Future Release to 2.3

I think most of this was done for 2.2, but I'm going to mark it as 2.3 officially.

Could someone mark it as fixed, please? :)

#26 @tw2113
4 years ago

In 9848:

Fixes documentation changes for some filters.

Props ecehren.

See #5940, #5941, #5943.

#27 @DJPaul
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#28 @tw2113
4 years ago

In 10020:

Adds hooks documentation to new hooks for BuddyPress 2.4.0.

See #5943.

#29 @DJPaul
3 years ago

  • Type changed from task to enhancement
Note: See TracTickets for help on using tickets.