Multisite: Deleting a post that matches a BP page ID will wipe out the directory page mapping

[r-a-y]

r9177 introduced functionality to delete BP's directory page marker when the corresponding page ID is deleted.

Unfortunately, r9177 forgot to add a check to see if we're on the BP root blog.

The problem is if a sub-site deletes a post whose page ID matches a BP directory page ID, the BP directory page marker is removed.

Will try to write a unit test for this, but it's kind of hard to write a test to match post IDs.

BP forum thread that sparked this ticket: ​https://buddypress.org/support/topic/page-templates-disassociate/

[johnjamesjacoby]

Moving to 2.2.1.

This is a nasty bug causing data loss for multisite installations with a straightforward fix.

Thanks again, Ray.

[johnjamesjacoby]

In 9505:

When removing directory pages, bail if request is not made from the root site ID.

This prevents accidental data loss when deleting pages from non-root blogs.

Props r-a-y. See #6226. (2.2 branch, for 2.2.1)

[johnjamesjacoby]

In 9506:

When removing directory pages, bail if request is not made from the root site ID.

This prevents accidental data loss when deleting pages from non-root blogs.

Props r-a-y. See #6226. (2.2.1 tag)

[johnjamesjacoby]

In 9507:

When removing directory pages, bail if request is not made from the root site ID.

This prevents accidental data loss when deleting pages from non-root blogs.

Props r-a-y. See #6226. (trunk)

[r-a-y]

Corresponding unit test for #6226.

[johnjamesjacoby]

In 9509:

Unit test for bp_core_get_directory_pages(). Props r-a-y. See #6226 (trunk)

[johnjamesjacoby]

In 9510:

Unit test for bp_core_get_directory_pages(). Props r-a-y. See #6226 (2.2 branch)

[johnjamesjacoby]

Thanks Ray for the quick fixes.

Marking as resolved.