Changeset 9505

Timestamp:

02/17/2015 11:56:13 PM (10 years ago)

Author:

johnjamesjacoby

Message:

When removing directory pages, bail if request is not made from the root site ID.

This prevents accidental data loss when deleting pages from non-root blogs.

Props r-a-y. See #6226. (2.2 branch, for 2.2.1)

File:

• branches/2.2/src/bp-core/bp-core-functions.php (modified) (2 diffs)

branches/2.2/src/bp-core/bp-core-functions.php

@@ -626 +626 @@
  * Remove the entry from bp_pages when the corresponding WP page is deleted.
  *
+ * Bails early on multisite installations when not viewing the root site.
+ * @link https://buddypress.trac.wordpress.org/ticket/6226
+ *
  * @since BuddyPress (2.2.0)
  *
@@ -631 +634 @@
  */
 function bp_core_on_directory_page_delete( $post_id ) {
-    $page_ids = bp_core_get_directory_page_ids();
+
+    // Stop if we are not on the main BP root blog
+    if ( ! bp_is_root_blog() ) {
+        return;
+    }
+
+    $page_ids       = bp_core_get_directory_page_ids();
     $component_name = array_search( $post_id, $page_ids );