Opened 10 years ago
Closed 10 years ago
#6159 closed defect (bug) (fixed)
bp_activity_thumbnail_content_images() assumes img height/width is always set
Reported by: | DJPaul | Owned by: | DJPaul |
---|---|---|---|
Milestone: | 2.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Activity | Keywords: | has-patch |
Cc: |
Description
bp_activity_thumbnail_content_images parses <img>
tags in the main content of an activity object, when generating a summary for the activity stream.
The current implementation assumes that the img tag will always contain width=
and height=
properties. If the content doesn't contain these properties inside img tags, it causes PHP Warnings.
I discovered this while working on another feature patch, so I don't have an easy unit test ready to prove the bug, though I've attached a patch.
Attachments (1)
Change History (3)
Note: See
TracTickets for help on using
tickets.
In 9456: