Opened 10 years ago
Closed 9 years ago
#6136 closed defect (bug) (fixed)
ajaxurl js variable defined multiple times
Reported by: | slaFFik | Owned by: | slaFFik |
---|---|---|---|
Milestone: | 2.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | has-patch |
Cc: |
Description
In different parts of BuddyPress ajaxurl
is added to the site <head>
section multiple times:
Messages, Core, BP-Legacy
This results in several such outputs in html
var ajaxurl = 'http://bpge.ovi/wp-admin/admin-ajax.php';
In BuddyPress 2.1.1 and BuddyPress Trunk (as for now)
Attachments (1)
Change History (7)
#2
@
10 years ago
- Keywords needs-patch added; dev-feedback removed
- Milestone changed from Awaiting Review to Future Release
While it's true (as noted in #4670) that this'll always be an issue when multiple plugins are running, it's possible for us to be less redundant internally. If bp-core is defining ajaxurl on every page, it probably doesn't need to be done in the other places.
#3
@
9 years ago
- Keywords has-patch added; needs-patch removed
Seems @r-a-y fixed in Messages component a while ago, so 2 places are left: Core and BP-Legacy.
As per @boonebgorges suggestion I removed from BP-Legacy, see 6136.patch attached.
I brought this up awhile ago - #4670.
I tend to agree with you though.