Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#6135 closed enhancement (fixed)

Update HTTPS domain for Gravatar image links

Reported by: djpaul's profile DJPaul Owned by: djpaul's profile DJPaul
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: good-first-bug has-patch
Cc:

Description

Currently we use {0-2|www}.gravatar.com for HTTP requests and secure.gravatar.com for HTTPS requests.

We can switch to using www.gravatar.com as it supports both HTTP and HTTPS now, which will let us simplify parts of our codebase. The numeric subdomains also support both protocols, but I think using WWW is going to be slightly more reliable in the long term in case the names of the CDN ever change.

Attachments (1)

6135.01.patch​ (10.8 KB) - added by DJPaul 10 years ago.

Download all attachments as: .zip

Change History (5)

#1 @DJPaul
10 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

@DJPaul
10 years ago

#2 @DJPaul
10 years ago

  • Keywords has-patch added

Have done research and decided www.gravatar.com is best to use. I've uploaded 6135.01.patch, tested on both HTTP and HTTPS.

#3 @djpaul
10 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 9455:

Core: use //www.gravatar.com for all image links.

www.gravatar.com supports HTTP and HTTPs, and by switching to protocol-relative URLs, we can simply the code by removing a number of is_ssl() checks.

Fixes #6135

#4 @DJPaul
8 years ago

  • Component changed from API - Avatars to Media
Note: See TracTickets for help on using tickets.