Persistent "repair" message in admin for people allowing registration

[imath]

Since r9177 even if we define the pages for registration and activation, the message inviting us to repair the page association keeps on showing.

That's because these two pages are not components and the following check is not taking this fact in account :

if ( ! bp_is_active( $component_name ) || 'trash' == get_post_status( $page_id ) ) {
	unset( $page_ids[ $component_name ] );
}

[boonebgorges]

In 9180:

Don't remove Register and Activate pages from bp_core_get_directory_page_ids().

These two pages do not correspond to components, so they should be excluded
from bp_is_active() checks.

Props imath.
Fixes #6043.

[imath]

I'm sorry, but r9180 is not fixing the issue on my config (WP & BP Trunk Multisite). My original patch does, but i have no idea why your commit is not fixing it :( Very strange.

[imath]

I think my patch is working because it's the wrong way to solve the issue, the correct check should be ! empty() in my case, and then it fails. Your commit is the good way, but it looks like the function is running twice.

the first time bp_get_signup_allowed() is false and the second time it's true.

[boonebgorges]

Thanks, imath. The problem is that the admin notice is being built before $bp->site_options is being populated. The result is that the 'registration' value is not yet loaded, which causes bp_get_signup_allowed() to return false.

I'm going to put in a band-aid fix for the time being, just to get this to work properly. I'll open a ticket for a broader fix.

[boonebgorges]

In 9189:

Ensure site_options have been loaded in bp_get_signup_allowed().

This function is sometimes run before $bp->site_options has been populated,
resulting in incorrect 'registration' values.

Fixes #6043.

[imath]

Thanks a lot boonebgorges :)

[boonebgorges]

#6045 is the new ticket.

Thanks for your help, imath.