Unable to page through search results

[bomako]

I am using WordPress 3.9.2 and BuddyPress 2.1. I have a custom field for a building name where people live. The sample values are "~ Aspen ~", "~ Park Manor ~", "~ Duplex Homes ~". Each member has something selected. If I go to the member page and click on the link of their building name, I am taken to a URL ending with (for example) "?s=~+Cottage+Homes+~" and the search results are loaded. But when I try to paginate through those results, the URL changes to "?upage=2&s=~CottageHomes~" and I get a message saying "Sorry, no members were found." It appears that all the spaces are stripped from the search. If I insert the spaces in the URL, the second page displays members just fine.

[imath]

Hi bomako

Thanks for your feedback. It seems to be a side effect of r8928. I suggest the attach patched.

BTW, i was wondering if there were a specific reason why in the member's dir search form, the search term was displayed as a placeholder instead of the input value ?

[imath]

Worked on a unit test. And it made me edit my previous patch ;)

See 5898-02.patch & 5898-02-unittest.patch

[boonebgorges]

Thanks, imath! Couple notes on the test:

• Could you make the method name a bit more descriptive? Maybe test_bp_has_members_search_pagination_with_spaces()
• Should be @ticket BP5898
• Clean up the $members_template global or you may pollute later tests

[imath]

Replying to boonebgorges:

Thanks, imath!

You're welcome ;)

Applied your notes in 5898-03-unittest.patch except for @ticket BP5898 as for some weird reason, the test is skipped in this case. So i've used @ticket bp5898 instead.

[boonebgorges]

except for @ticket BP5898 as for some weird reason, the test is skipped in this case. So i've used @ticket bp5898 instead.

This is by design - tests that are associated with open tickets are skipped, unless (a) you run them explicitly (phpunit --group BP5898) or (b) you define WP_TESTS_FORCE_KNOWN_BUGS as true in wp-tests-config.php. The fact that the test was being skipped when running phpunit means that you had the annotation correct :)

Also, forgot to mention in my last comment - don't check ! empty( $matches[1] ). You're doing that to avoid PHP notices, which is good practice in BuddyPress, but in a unit test, we want to see the error when your regex doesn't match anything so we know that the test has failed!

[imath]

Well phpunit --BP5898 was also skipping the test. Updated the unittest, thanks a lot for the explanations ;)

[boonebgorges]

phpunit --group BP5898 :)

Thanks for the fixes!

[imath]

yep that's what i did ;) i mistyped in my previous comment !! Thanks a lot for your help :)

[imath]

In 9044:

On members directory, make sure search terms containing spaces are well transported in pagination links.

When a profile field output containing spaces was clicked, the member search functionality wasn't creating consistent pagination links. This behavior was introduced by r8928. Patch is fixing the issue and also includes a unit test.

props boonebgorges

See #5898

[imath]

In 9045:

On members directory, make sure search terms containing spaces are well transported in pagination links.

When a profile field output containing spaces was clicked, the member search functionality wasn't creating consistent pagination links. This behavior was introduced by r8928. Patch is fixing the issue and also includes a unit test.

props boonebgorges

Fixes #5898