Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#5892 closed defect (bug) (fixed)

bp-default: missing suggestions for @mentions

Reported by: m@… Owned by:
Milestone: 2.1.1 Priority: normal
Severity: normal Version: 2.1
Component: Templates Keywords: has-patch
Cc:

Description

Looks as progress like @mentions were forgotten to get ported back to good ol’ bp-default. In bp-activity/js/mentions.js you’ll find on what elements @mentions should work:

// Activity/reply, post comments, dashboard post 'text' editor.
$( '.bp-suggestions, #comments form textarea, .wp-editor-area' ).bp_mentions( users );

The selector class 'bp-suggestions' is currently missing in bp-default.

I created a pull request: https://github.com/buddypress/BP-Default/pull/2/files

Change History (3)

#2 @r-a-y
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for the pull request, m@rk. I just merged in the changes on Github:
https://github.com/buddypress/BP-Default/commit/b613fda3e844b0af5ed9c1b0d8b7b16e7438da45

As to why suggestions support for bp-default was not added initially, since BP v1.9, the core team began phasing out support for bp-default:
http://bpdevel.wordpress.com/2013/11/13/the-future-of-the-bp-default-theme/

The team will maintain bugfixes and security issues, but feature development for bp-default has essentially ended. However, we will accept pull requests from the community and are looking for better ways for contributors to get involved.

Thanks again!

#3 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.