#5891 closed enhancement (fixed)
scrutinizer-ci.com master ticket
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 2.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | |
Cc: | stephen@… |
Description
scrutinizer-ci.com is a static code analysis tool. I've set up a (provisional) account for BuddyPress, and you can see the reports here: https://scrutinizer-ci.com/g/buddypress/BuddyPress/issues/master
While I don't know if it's something worthwhile to use in the long term, I think it is worthwhile if we take a look at its feedback over the next couple of BuddyPress releases. I'm beginning to look through the reports and will create tickets as necessary.
Let's use this as a master ticket for discussion of scrutinizer-ci and to link to reported tickets.
Change History (24)
#3
@
10 years ago
Yes, it cleared the warnings it had found (and then added some more, yay): https://scrutinizer-ci.com/g/buddypress/BuddyPress/inspections/4ccdf139-b4d6-40d0-96cd-22e66b5c1cb4
Maybe we should just treat this as a phpDoc sprint sometime.
#4
follow-up:
↓ 5
@
10 years ago
- Cc stephen@… added
This is cool, I ran bbPress though scrutinizer-ci a couple of months ago, it wasn't pretty ;)
Some FYI:
- @WonderboyMusic also ran WordPress through Scrutinizer CI, a couple of his notes here.
- I've been messing about with PHPCS and bbPress and happened upon this:WordPress-Coding-Standards
- @JohnJamesJacoby has also been code sniffing, though I'm not sure with what though ;) [bbPress5466]
#5
in reply to:
↑ 4
@
10 years ago
Replying to netweb:
- @JohnJamesJacoby has also been code sniffing, though I'm not sure with what though ;) [bbPress5466]
A decent write-up of my approximate process here: https://rtcamp.com/tutorials/standards/php/code-sniffer/
#24
@
8 years ago
- Milestone changed from Future Release to 2.8
- Resolution set to fixed
- Status changed from new to closed
I'm going to close this ticket. Scrutinizer-CI seems to have little value and is very complex to try to set up correctly, but as it's in place, we may as well keep the integration until some part of it is replaced with something.
I've looked through a few files so far and it seems that a fairly common source of issues are mistakes in our phpDoc blocks (wrong return type specified, typo in the phpDoc syntax, and so on). I'm going to commit a small phpDoc correction for one file and then see/confirm if that change makes scrutinizer happy, or if I've misunderstood what we need to fix.