Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 4 years ago

Last modified 4 years ago

#5759 closed enhancement (wontfix)

Send Invites HTML is hard-coded, displayed in a different way than with template, causes inconsistencies

Reported by: jreeve Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Templates Keywords: needs-patch
Cc:

Description

It's possible to control the way users in Groups -> Send Invites list are displayed by putting groups/single/send-invites.php in one's theme, but these changes don't apply to the HTML returned by AJAX, which remains unthemed. This could cause inconsistencies. For example, if a user has already invited a few friends, those friends appear themed by send-invites.php, but if that user clicks the checkboxes to invite more friends, the new friends will display according to the AJAX HTML, which is in the function bp_dtheme_ajax_invite_user().

Screenshots and more discussion at my github issue: https://github.com/mlaa/cbox-mla/issues/52

Change History (12)

#1 @DJPaul
7 years ago

  • Component changed from Groups to Theme
  • Keywords 2nd-opinion added

This sounds like a BP-Default problem I'm not sure it's worth fixing since we've deprecated that theme. I guess if the same issue still occurs with the theme compat. templates, we should fix it, otherwise not. Be interested in more opinions, especially from other people with CBOX experience. :)

#2 @jreeve
7 years ago

Oh wow. I hadn't heard anything about BP-Default being deprecated. Where can I find this new theme?

#3 @DJPaul
7 years ago

I'm struggling to quickly find a good blog post, but https://bpdevel.wordpress.com/2014/04/16/grunt-coming-to-buddypress/ kind of hints at it. We aren't replacing it with a new WordPress theme, but are instead relying on our theme compatibility template parts (e.g. switch your site to twentytwelve, and BuddyPress content still works -- that's the theme compatibility parts).

#4 @r-a-y
7 years ago

  • Keywords 2nd-opinion removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

I think this is more of an issue with cbox-theme as bp-default shows the invite templates fine.

cbox-theme uses bp-default templates for its BuddyPress support. It would be great if cbox-theme followed BP's theme compatibility, but that is a separate subject for the CBOX project ;)

Last edited 7 years ago by r-a-y (previous) (diff)

#5 @jreeve
7 years ago

  • Keywords 2nd-opinion added

So if I wanted to write a CBOX/Buddypress theme that would be forward-compatible, what template files would I need to start with?

#6 @r-a-y
7 years ago

  • Keywords 2nd-opinion removed

So if I wanted to write a CBOX/Buddypress theme that would be forward-compatible, what template files would I need to start with?

For cbox-theme / bp-default, you would follow this guide:
http://codex.buddypress.org/themes/theme-compatibility-1-7/bp-17-upgrading-template-packed-themes/

This would remove the old bp-default templates and BuddyPress will attempt to fill in the blanks by injecting its own templates and stylesheet.

Chances are cbox-theme will need some CSS refinements to match the new CSS selectors. I would open an issue on the cbox-theme Github repo discussing a potential move to BP's theme compatibility.

And then to override the newer theme compatibility templates, follow this guide:
http://codex.buddypress.org/themes/theme-compatibility-1-7/theme-compatibility-2/

I would also create a ticket discussing the group invite template styles that appear to be missing in the current templates.

Thanks jreeve!

Last edited 7 years ago by r-a-y (previous) (diff)

#7 @r-a-y
7 years ago

  • Component changed from Theme to Template Pack
  • Keywords needs-patch added
  • Milestone set to Future Release
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Type changed from defect (bug) to enhancement
  • Version 2.0 deleted

After re-reading the original ticket description, jreeve's point is valid. The group invites template loop and the AJAX output function uses two different techniques. The AJAX output function should preferably reference a BP template part.

BP's theme compatibility still has this issue as it's a carryover from the bp-default days.

We'd probably need to introduce a new template like /groups/single/invite-loop-item.php to accommodate this change.

Last edited 7 years ago by r-a-y (previous) (diff)

#8 @jreeve
7 years ago

Thanks r-a-y! For the next big rewrite of our theme, I'll see if I can circumvent CBOX and use the more up-to-date BuddyPress templates. I'll open an issue at cbox-theme, too.

#9 @DJPaul
6 years ago

  • Component changed from Appearance - Template Pack to Appearance - Template Parts

#10 @DJPaul
6 years ago

  • Component changed from Appearance - Template Parts to Templates

#11 @DJPaul
4 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

#12 @DJPaul
4 years ago

Closing most tickets related to BP-Default and BP-Legacy, since the upcoming BP-Nouveau template pack (planned for 3.0) will make these redundant.

Note: See TracTickets for help on using tickets.