Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

#5702 closed defect (bug) (fixed)

__DIR__ predefined constant in gruntified trunk loader

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 2.1 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch commit
Cc:

Description (last modified by imath)

WordPress PHP min required version is 5.2.4 and the __DIR__ was introduced in 5.3. As a result using WordPress min required version with trunk fails to load BuddyPress.

This is probably an edge case, but i think it would be best to use dirname( __FILE__ ) to be consistent with WordPress PHP min required version.

Attachments (1)

5702.patch​ (556 bytes) - added by imath 12 years ago.

Download all attachments as: .zip

Change History (6)

@imath
12 years ago

#1 @imath
12 years ago

  • Description modified (diff)

#2 follow-up: @r-a-y
12 years ago

I just marked #5658 as a duplicate.

I think this is good to go.

#3 in reply to: ↑ 2 @imath
12 years ago

Replying to r-a-y:

I think this is good to go.

Oops i missed the previous ticket :( sorry and thanks a lot for your feedback

#4 @DJPaul
12 years ago

  • Keywords commit added

Looks good

#5 @imath
12 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 8523:

Use dirname( FILE ) instead of DIR in trunk loader file

As WordPress minimum PHP required version is 5.2.4 and DIR was introduced in 5.3, we need to use dirname( FILE ) so that people can use the trunk version of BuddyPress if their PHP version is lower than 5.3.

props hnla, boonebgorges

Fixes #5702

Note: See TracTickets for help on using tickets.