Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 5 years ago

#5628 closed enhancement (fixed)

Update NPM grunt-contrib-imagemin

Reported by: netweb Owned by: djpaul
Milestone: 2.1 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch commit
Cc:

Description

Currently BuddyPress is using grunt-contrib-imagemin v0.4.1

The latest release is v0.7.0. https://www.npmjs.org/package/grunt-contrib-imagemin

Replying to ticket:5160#comment:35 djpaul:

In r8373:

Grunt: switch imagemin back to version 0.4.1. v0.6.1 has some dependency issue that doesn’t seem to be automatically resolved. Switching it back to the version of the package that WordPress core uses.

These dependency issues should now be been resolved.

Updating BuddyPress to use "grunt-contrib-imagemin": "~0.7.0"

Running grunt imagemin:core completes fine for me with no errors:

	Minified 30 images (saved 0 B)

	Done, without errors.

Related: #WP27340 #comment:5 #comment9 as to why WordPress still uses v0.4.1

Attachments (2)

5628.patch (473 bytes) - added by netweb 6 years ago.
5628.2.patch (489 bytes) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (7)

@netweb
6 years ago

#1 @netweb
6 years ago

  • Keywords has-patch added

#2 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to 2.1
  • Type changed from defect (bug) to enhancement

Sweet, thanks for the patch and keeping an eye on the upstream Grunt module.

#3 @DJPaul
6 years ago

  • Keywords commit added

This ticket was mentioned in IRC in #buddypress-dev by netweb. View the logs.


5 years ago

@netweb
5 years ago

#5 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 8483:

Grunt: update grunt-contrib-imagemin to 0.7.1

Fixes #5628, props netweb

Note: See TracTickets for help on using tickets.