Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

#5627 closed defect (bug) (fixed)

Update phpunit grunt task to not use deprecated util

Reported by: netweb's profile netweb Owned by: djpaul's profile djpaul
Milestone: 2.1 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch commit
Cc:

Description

Via ​#WP27343 and related ​#bbPress2542

Grunt is deprecating the Grunt.Util.* api

(mentioned in the 0.4.3 announcement ​http://gruntjs.com/blog/2014-03-07-grunt-0.4.3-released
and the 0.4.2 announcement ​http://gruntjs.com/blog/2013-11-21-grunt-0.4.2-released)

Once WordPress has a working patch upstream this should be implemented here.

Attachments (2)

5627.diff​ (995 bytes) - added by netweb 11 years ago.
5627.2.diff​ (993 bytes) - added by netweb 11 years ago.

Download all attachments as: .zip

Change History (8)

#1 @DJPaul
11 years ago

  • Milestone changed from Awaiting Review to Future Release

Thanks for keeping an eye on the upstream Grunt module releases.

@netweb
11 years ago

#2 @netweb
11 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to Awaiting Review

Upstream via ​27343 we have gone with the method to include grunt-legacy-util

In 5627.diff:
Grunt is deprecating the Grunt.Util.* api, adding grunt-legacy-util will allow us to continue using grunt.util.spawn to spawn the multiple phpunit Grunt tasks.

  • Adds grunt-legacy-util to package.json
  • Requires fresh npm install to update dependencies

@netweb
11 years ago

#3 @netweb
11 years ago

Patch 5627.2.diff​ updates 5627.diff​ with correct whitespace.

#4 @DJPaul
11 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.1

This ticket was mentioned in IRC in #buddypress-dev by netweb. ​View the logs.
11 years ago

#6 @djpaul
11 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 8487:

Grunt: Update phpunit grunt task to not use deprecated util

Fixes #5627, props netweb

Note: See TracTickets for help on using tickets.