Nested activity comments do not show when logged out

[r-a-y]

Reported here:
http://buddypress.org/support/topic/show-activity-comments-to-everybody/

Problem occurs because we have a is_user_logged_in() check before activity comments are rendered.

This change was added in r4691 in bp-default and ported over to bp-legacy.

Any reason why this is done? Since this is quite old and no one has really reported it until now, is it an issue?

[boonebgorges]

Weird. I assume that bp_activity_can_comment() was a poor-man's way of checking whether comments could exist for the given activity item. (The commit message is not very explicit and there is no linked ticket :-/)

IMO, the proper logic is something like: show the activity section if one of the following is true:

• there are existing comments (which anyone would be able to see, whether logged in or not)
• the current user is logged in + commenting on this activity item is permitted (in which case we need to show the comment form)

In other words:

if ( bp_activity_get_comment_count() || ( is_user_logged_in() && bp_activity_can_comment() ) )

Does that seem right?

[DJPaul]

I think we should move the is_user_logged_in check inside the bp_activity_can_comment as that seems a logical place. Would be nice if someone catch patch this or Boone's suggestion together for 2.1; I'm not fussed either way.

[wolfhoundjesse]

Good morning,

I changed the check so that existing comments would be displayed:

• if they indeed exist
• if comments are allowed on this particular activity

I left the check for whether or not the activity is_single. If the user is logged in and comments are allowed, display the comment form.

I completed the OpenHatch missions, but I'm very new to SVN. I'll attach a diff so that you can offer some guidance/criticism/taunts!

[DJPaul]

Patch looks good.

[djpaul]

In 8762:

Activity: fix bug where activity comments were not being shown to anonymous users.

Fixes #5567, props wolfhoundjesse

[DJPaul]

Thanks so much for the patch, wolfhoundjesse :)

[wrowlands]

When will this fix be added to the plugin and distributed?

[r-a-y]

When will this fix be added to the plugin and distributed?

When v2.1 is released, which is scheduled around a month from now.

If you need to, you can roll the fix on your own install by copying the changes in r8762.

[wrowlands]

This worked GREAT! Thanks for your help.

Wayne