Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#5534 closed defect (bug) (fixed)

Fix missing i18n text domains

Reported by: netweb's profile netweb Owned by: boonebgorges's profile boonebgorges
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Cc:

Description 

$ grunt checktextdomain
Running "checktextdomain:files" (checktextdomain) task

src/bp-core/admin/bp-core-functions.php
[L845]  __  Missing text domain
[L847]  __  Missing text domain

src/bp-members/admin/bp-members-classes.php
[L148]  __  Missing text domain
[L226]  __  Missing text domain
[L466]  __  Missing text domain
[L539]  __  Missing text domain

src/bp-members/bp-members-admin.php
[L1294]  esc_html_x  Missing text domain
[L1296]  esc_html_x  Missing text domain
[L1300]  __          Missing text domain

src/bp-members/bp-members-functions.php
[L1587]  __  Missing text domain

✖ 10 problems

The build tools makes this so easy to check :)

$ grunt checktextdomain
Running "checktextdomain:files" (checktextdomain) task

✔ No problems

Done, without errors.

Attachments (1)

5534.diff​ (5.0 KB) - added by netweb 10 years ago.

Download all attachments as: .zip

Change History (4)

@netweb
10 years ago

#1 @boonebgorges
10 years ago

The build tools makes this so easy to check :)

The missing textdomains are not an oversight, but were sorta intentional, due to the fact that the strings are taken directly from WP in places where we intend to copy core UI. But after consulting with team, it sounds like this is not a practice that we want to adopt.

#2 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 8272:

Add 'buddypress' textdomain to strings in bp-members

Fixes #5534

Props netweb

#3 @DJPaul
8 years ago

  • Component changed from Locale - i18n to I18N
Note: See TracTickets for help on using tickets.