Skip to:

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#5446 closed defect (bug) (fixed)

Wrong behavior in notifications for group membership requests

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 2.0 Priority: normal
Severity: normal Version: 1.9.2
Component: Groups Keywords: has-patch needs-testing commit


I've found some weird behavior in group memberships requests notifications:

  1. In the email, the link to the email notifications settings is not the one of the group administrator but the one of the user requesting the membership.
  2. In notifications table, the field item_id should be populated by the group id instead of the id of the user requesting the membership. Else, when a group is deleted it generates errors and a blank group page. In this case, bp_groups_delete_group_delete_all_notifications() is trying to delete notifications where the item id is the group id and has few chances to find it.

I think the suggested patch is solving the issue.

Attachments (1)

5446.diff (2.3 KB) - added by imath 10 years ago.

Download all attachments as: .zip

Change History (5)

10 years ago

#1 @boonebgorges
10 years ago

This looks good to me.

#2 @DJPaul
10 years ago

  • Keywords commit added

Looks good here, too.

#3 @imath
10 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 8037:

Set bp_notifications_add_notification() arguments correctly in case of a new_membership_request

The group id needs to be the item_id argument of bp_notifications_add_notification() in case a member requested to join the group. The patch also makes sure the link to the user notification settings page is the one of the administrator of the group in the email sent to inform him of a new membership request.

Fixes #5446

#4 @johnjamesjacoby
10 years ago

Possible I swapped this on accident when adding the Notifications component. Any way to tell if this was a regression in 1.9, or if this just never worked correctly?

Note: See TracTickets for help on using tickets.