Skip to:

Opened 10 years ago

Closed 10 years ago

#5447 closed defect (bug) (fixed)

Posting an activity reload the last activity into the stream

Reported by: imath's profile imath Owned by: imath's profile imath
Milestone: 2.0 Priority: normal
Severity: normal Version:
Component: Activity Keywords: has-patch commit


Since the introduction of the "heartbeat check", posting an activity uses the offset argument to load the just posted activity and the activities that might have been posted by others in the meantime.

Offset is requesting ">=" and we're passing the last displayed id on the stream. As a result, this last displayed activity is reloaded.

I think it's something we forgot to implement when posting a new activity as we're adding +1 to the offset argument in bp_activity_heartbeat_last_recorded() function.

The patch simply adds +1 when requesting for activities once a new activity is posted in bp_legacy_theme_post_update()

Attachments (1)

5447.diff (754 bytes) - added by imath 10 years ago.

Download all attachments as: .zip

Change History (5)

10 years ago

#1 @imath
10 years ago

  • Milestone changed from Awaiting Review to 2.0

#2 follow-up: @boonebgorges
10 years ago

  • Component changed from Core to Activity
  • Keywords commit added

Sorry, this is my fault. Fix looks good.

#3 in reply to: ↑ 2 @imath
10 years ago

Replying to boonebgorges:

Sorry, this is my fault. Fix looks good.

No problem :) Thanks.

#4 @imath
10 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 8048:

Prevent the last displayed activity on stream to be reloaded after a posted update

Since the introduction of the heartbeat feature to automatically check for new activities, when posting an update: an offset argument is used to load all new activities. This offset is given by the last activity id displayed on the stream, to be sure that specific activity is not reloaded, we need to increment this id by 1.

Fixes #5447

Note: See TracTickets for help on using tickets.