Members search & WP 3.9 since WP changeset 27257

[imath]

With latest WordPress trunk, if you perform a member search, this will trigger a warning error and will break the search.

Reason is the use of mysql_real_escape_string to escape the search_terms in BP_User_Query. Seems the mysql connexion is not available when using this function, so the second argument is necessary.

We could use $wpdb->_real_escape() instead. But i think, esc_sql() can also do the job.

BP_Signup::get (#5374) will also be concerned.

Finally mysql_real_escape_string is ​deprecated as of PHP 5.5.0

[boonebgorges]

In 7993:

Don't use mysql_real_escape_string() in BP_User_Query

Fixes #5432

Props imath