Changes to BP_Activity_Activity::get_last_updated() to get last id depending on contexts

[imath]

This patch suggests to modify BP_Activity_Activity::get_last_updated() in order to be able to get the last updated id for a context defined in arguments.
This is a reply to the 3rd point of DJPaul in his ​comment to #5328

PS : i haven't find a core function to help us build the query, there's the method BP_Activity_Activity::get_id() that is approaching but would need to be changed to edit the search argument and to add an exclude argument, as 'last_activity' is a type of activity the "load newest" feature needs to exclude.

[boonebgorges]

In 7922:

Unit test for BP_Activity_Activity::get_last_updated()

See #5409

[boonebgorges]

imath - Thanks for putting this into a separate ticket.

I'm not convinced that extending get_last_updated() in this way is appropriate. If I understand ​https://buddypress.trac.wordpress.org/attachment/ticket/5328/5328.02.diff correctly, you could just use bp_activity_get() for your purposes. In bp_activity_heartbeat_last_recorded():

$activities = bp_activity_get( array(
    'search_terms'      => $data['bp_last_activity_update']['search'],
    'filter'            => $filter,
    'show_hidden'       => $show_hidden,
    'max'               => 1,
    'per_page'          => 1,
    'update_meta_cache' => false,
) );

if ( ! empty( $activities['activities'] ) ) {
    $response['last_id_recorded'] = $activities['activities'][0]->id;
}

It seems to me that we should move toward centralizing all of our component queries when possible, not reproducing query logic. This looks to me like a case where we can easily leverage the tools we already have. What do you think, imath?

[imath]

Replying to boonebgorges:

What do you think, imath?

I think i was too obsessed by only getting the id and no other data! I really need to explore the way you suggest and "rethink" the way i was loading newest activities. Thanks a lot boonebgorges :)
Excited! I'll check this asap!!

[imath]

I confirm, it's best to use bp_activity_get() :)
Actually as i explained in point a) of this ​comment on #5328 i'm using an activity loop.

As you've added unit test, i'm not sure i should close this ticket.

[boonebgorges]

Cool, thanks!

I wrote the unit test knowing that we might close this ticket as invalid. It doesn't hurt to have it :)