Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#5366 closed defect (bug) (fixed)

Script must not have attribute charset unless attribute src is also specified

Reported by: henrywright's profile henry.wright Owned by: r-a-y's profile r-a-y
Milestone: 2.0 Priority: normal
Severity: normal Version: 1.9.1
Component: Appearance - Template Pack Keywords: has-patch
Cc:

Description

When the AJAX url is put in the header by buddypress-functions.php (see function head_scripts() on line 336), the ​W3C Validator gives an error:

"Element script must not have attribute charset unless attribute src is also specified"

The same issue was resolved over at bbPress recently:
​https://bbpress.trac.wordpress.org/ticket/1959

Please find patch attached.

Attachments (1)

5366.patch​ (431 bytes) - added by henry.wright 11 years ago.

Download all attachments as: .zip

Change History (5)

@henry.wright
11 years ago

#1 @henry.wright
11 years ago

  • Keywords has-patch added

#2 @r-a-y
11 years ago

  • Component changed from Core to Template Pack
  • Milestone changed from Awaiting Review to 2.0

#3 @r-a-y
11 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 8141:

bp-legacy: Remove charset attribute for <script> call.

This is invalid HTML.

Fixes #5366

Props henry.wright

#4 @r-a-y
11 years ago

Thanks for the patch, henry.wright!

Note: See TracTickets for help on using tickets.