Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

#5316 closed defect (bug) (fixed)

One semicolon too many at the messages template

Reported by: macpresss's profile MacPresss Owned by: boonebgorges's profile boonebgorges
Milestone: 2.0 Priority: normal
Severity: minor Version: 1.9.1
Component: Messages Keywords: has-patch
Cc:

Description

One semicolon too mant at the messages.php template.

Line 57

Old:

<?php bp_get_template_part( 'members/single/messages/notices-loop' );; ?>

New:

<?php bp_get_template_part( 'members/single/messages/notices-loop' ); ?>

Attachments (1)

messages.php​ (1.3 KB) - added by MacPresss 11 years ago.
Patch ?

Download all attachments as: .zip

Change History (3)

@MacPresss
11 years ago

Patch ?

#1 @boonebgorges
11 years ago

  • Milestone changed from Awaiting Review to 2.0
  • Type changed from enhancement to defect (bug)

Good catch!

(You've submitted a full PHP file rather than a patch against a SVN checkout. Here's a pretty straightforward guide to getting a SVN dev environment setup and using TortoiseSVN to generate patch files: ​http://www.doitwithwp.com/submit-patch-wordpress-core-beginners/ It's for WP, but you can apply the same ideas to BP. Our SVN trunk address is ​http://buddypress.svn.wordpress.org/trunk.)

#2 @boonebgorges
11 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7717:

Remove duplicate semicolon in messages template.

Fixes #5316

Props MacPresss

Note: See TracTickets for help on using tickets.