Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

#5315 closed enhancement (fixed)

Add ability to query both read and unread notifications

Reported by: rodrigorznd Owned by: boonebgorges
Milestone: 2.0 Priority: normal
Severity: normal Version: 1.9
Component: Toolbar & Notifications Keywords: has-patch 2nd-opinion needs-unit-tests needs-testing
Cc:

Description (last modified by johnjamesjacoby)

Attached patch allows loading read and unread notifications in the same query.

Attachments (1)

buddypress.patch (801 bytes) - added by rodrigorznd 7 years ago.

Download all attachments as: .zip

Change History (6)

#1 @johnjamesjacoby
7 years ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 2.0
  • Summary changed from Loading read and unread notifications to Add ability to query both read and unread notifications

#2 @DJPaul
7 years ago

Needs testing, and unit tests would be extra nice to ensure we don't break this in future, but I don't see any harm in adding this patch.

#3 @DJPaul
7 years ago

  • Keywords 2nd-opinion needs-unit-tests needs-testing added

#4 @boonebgorges
7 years ago

+1 DJPaul. The unit tests will take someone about ten minutes to write; just copy one of the existing tests and make some minor mods.

#5 @boonebgorges
7 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 8167:

Allow all notifications to be fetched by passing 'both' to is_new param of BP_Notifications_Notification::get()

Fixes #5315

Props rodrigorznd

Note: See TracTickets for help on using tickets.