Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#5309 closed defect (bug) (fixed)

Remove unecessary wpdp->prepare

Reported by: graham washbrook Owned by: djpaul
Priority: normal Milestone: 2.0
Component: Extended Profile Version: 1.0
Severity: trivial Keywords: has-patch
Cc:

Description

Prepare call isn’t doing anything as there are no inputs.

Fixes WARNING: Missing argument 2 for wpdb::prepare(), called in \buddypress\bp-xprofile\bp-xprofile-classes.php on line 1268

Ref:
​http://make.wordpress.org/core/2012/12/12/php-warning-missing-argument-2-for-wpdb-prepare/

Attachments (1)

bp-xprofile-classes.php.patch​ (678 bytes ) - added by graham washbrook 13 years ago.

Download all attachments as: .zip

Change History (3)

@graham washbrook
13 years ago

#1 @DJPaul
13 years ago

  • Milestone Awaiting Review → 2.0
  • Version 1.9 → 1.0

Thanks Graham, and good spot. We probably missed this because it's not a function used anywhere in core nowadays -- it used to be used for a "select random profile" button in the original theme (v1.0 - v1.2, ish).

#2 @djpaul
13 years ago

  • Owner set to djpaul
  • Resolution → fixed
  • Status new → closed

In 7710:

xprofile: remove unnecessary $wpdb->prepare in BP_XProfile_ProfileData->get_random().

Props graham-washbrook for initial patch, fixes #5309

Note: See TracTickets for help on using tickets.