Skip to:

Opened 11 years ago

Closed 11 years ago

#5309 closed defect (bug) (fixed)

Remove unecessary wpdp->prepare

Reported by: graham-washbrook's profile graham washbrook Owned by: djpaul's profile djpaul
Milestone: 2.0 Priority: normal
Severity: trivial Version: 1.0
Component: Extended Profile Keywords: has-patch


Prepare call isn’t doing anything as there are no inputs.

Fixes WARNING: Missing argument 2 for wpdb::prepare(), called in \buddypress\bp-xprofile\bp-xprofile-classes.php on line 1268


Attachments (1)

bp-xprofile-classes.php.patch (678 bytes) - added by graham washbrook 11 years ago.

Download all attachments as: .zip

Change History (3)

#1 @DJPaul
11 years ago

  • Milestone changed from Awaiting Review to 2.0
  • Version changed from 1.9 to 1.0

Thanks Graham, and good spot. We probably missed this because it's not a function used anywhere in core nowadays -- it used to be used for a "select random profile" button in the original theme (v1.0 - v1.2, ish).

#2 @djpaul
11 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 7710:

xprofile: remove unnecessary $wpdb->prepare in BP_XProfile_ProfileData->get_random().

Props graham-washbrook for initial patch, fixes #5309

Note: See TracTickets for help on using tickets.