Orphan notifications when item is deleted

[colabsadmin]

When deleting anything that has a notification associated with it, it should also delete the notifications. Here’s a screen cap of the notifications panel showing blank subjects because the post/update/topic was deleted.

[colabsadmin]

Orphan Notification

[r-a-y]

Is this only specific to notifications generated by the bbPress plugin?

Does this happen to any of BP's core components?

[colabsadmin]

No. It happens in groups as well.

[henry.wright]

I think there might be an opportunity here to address two similar issues.

What happens to a notification when the item is:

a) permanently deleted. For example, hitting the delete button on a blog post containing an at-mention.
b) removed. For example, a blog post is edited to remove a previously published bit of text containing an at-mention.

My suggestion would be to delete the notification from both the unread and read list in both of the above cases.

Thoughts?

[boonebgorges]

My suggestion would be to delete the notification from both the unread and read list in both of the above cases.

Yes, this sounds fine to me.

[slaFFik]

Just tested this with the latest BuddyPress - removing parent item does remove notification sent to a mention user from both read and unread. Testing with blog posts, comments, status updates.