Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5293 closed defect (bug) (fixed)

In case of friendship is cancelled, notification isn't although code is in 1.9-beta2

Reported by: imath's profile imath Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.9 Priority: normal
Severity: minor Version:
Component: Friends Keywords: has-patch
Cc:

Description

I think it's best, i create another ticket, because i think this part was a bit difficult to see in #5289

In bp-friends-notifications.php bp_friends_mark_friendship_withdrawn_notifications_by_item_id() is there to delete the notifications in case a friendship has been cancelled, trouble is that the hook is not played as friends_friendship_withdrawn doesn't exist.

I suggest the attached diff to use friends_friendship_whithdrawn instead

Attachments (1)

5293.diff (752 bytes) - added by imath 10 years ago.

Download all attachments as: .zip

Change History (3)

@imath
10 years ago

#1 @johnjamesjacoby
10 years ago

  • Milestone changed from Awaiting Review to 1.9

#2 @johnjamesjacoby
10 years ago

  • Owner set to johnjamesjacoby
  • Resolution set to fixed
  • Status changed from new to closed

In 7673:

Fix typo in friends_withdraw_friendship() introduced in r5931. See #3897. Fixes #5293.

Note: See TracTickets for help on using tickets.