"Friendship requested" button should not be disabled

[r-a-y]

When a displayed user's friendship is pending, the logged-in user should be able to click on the "Friendship requested" button to manage the request.

However, due to the JS here:
​https://buddypress.trac.wordpress.org/browser/tags/1.5.2/bp-themes/bp-default/_inc/global.js#L844

The link is disabled.

One way to remedy this is to add a CSS class to the "pending" friendship button called "no-disable". Then in the JS, use hasClass to check if this CSS exists. If it does, let the link through.

[DJPaul]

When you say "manage the request", what do you mean you think should happen? Where does the link go to in this situation?

[r-a-y]

Default link goes to /members/USERNAME/friends/requests/.

But since the logged-in user can't click on the link, they have to somehow find their way to the friendship requests page.

It's a small UX issue.

[boonebgorges]

USERNAME's *sent* friendship requests don't show up at /members/USERNAME/friends/requests/ - only the requests he has *received*. So there's nothing really to manage.

Maybe this shouldn't be a link at all?

[johnjamesjacoby]

Probably shouldn't be a button. If it is, it should be clickable and do something. Maybe "Unfriend" or "Undo" and put them back in pending status?

[ddean]

Proposal to wire up the friendship pending button

[ddean]

Being able to cancel requests seems like a nice feature. Maybe the /members/USERNAME/friends/requests/ page could show incoming and outgoing requests.

Here's a patch that makes the "Friendship Requested" pseudo-button into a "Cancel Friendship Request" button.

[johnjamesjacoby]

(In [5931]) Add the ability to cancel a pending friendship request. Props ddean. Fixes #3897.

[johnjamesjacoby]

In 7673:

Fix typo in friends_withdraw_friendship() introduced in r5931. See #3897. Fixes #5293.