Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#3897 closed defect (bug) (fixed)

"Friendship requested" button should not be disabled

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.6 Priority: normal
Severity: normal Version: 1.5.4
Component: Templates Keywords: dev-feedback has-patch
Cc: david@…

Description

When a displayed user's friendship is pending, the logged-in user should be able to click on the "Friendship requested" button to manage the request.

However, due to the JS here:
https://buddypress.trac.wordpress.org/browser/tags/1.5.2/bp-themes/bp-default/_inc/global.js#L844

The link is disabled.

One way to remedy this is to add a CSS class to the "pending" friendship button called "no-disable". Then in the JS, use hasClass to check if this CSS exists. If it does, let the link through.

Attachments (1)

bp-cancel-friendship-request.patch (6.5 KB) - added by ddean 12 years ago.
Proposal to wire up the friendship pending button

Download all attachments as: .zip

Change History (10)

#1 @DJPaul
12 years ago

When you say "manage the request", what do you mean you think should happen? Where does the link go to in this situation?

#2 @r-a-y
12 years ago

Default link goes to /members/USERNAME/friends/requests/.

But since the logged-in user can't click on the link, they have to somehow find their way to the friendship requests page.

It's a small UX issue.

#3 @boonebgorges
12 years ago

USERNAME's *sent* friendship requests don't show up at /members/USERNAME/friends/requests/ - only the requests he has *received*. So there's nothing really to manage.

Maybe this shouldn't be a link at all?

#4 @johnjamesjacoby
12 years ago

  • Milestone changed from Awaiting Review to 1.6
  • Version changed from 1.2 to 1.5.4

Probably shouldn't be a button. If it is, it should be clickable and do something. Maybe "Unfriend" or "Undo" and put them back in pending status?

@ddean
12 years ago

Proposal to wire up the friendship pending button

#5 @ddean
12 years ago

  • Cc david@… added

Being able to cancel requests seems like a nice feature. Maybe the /members/USERNAME/friends/requests/ page could show incoming and outgoing requests.

Here's a patch that makes the "Friendship Requested" pseudo-button into a "Cancel Friendship Request" button.

#6 @ddean
12 years ago

  • Keywords has-patch added

#7 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5931]) Add the ability to cancel a pending friendship request. Props ddean. Fixes #3897.

#8 @johnjamesjacoby
10 years ago

In 7673:

Fix typo in friends_withdraw_friendship() introduced in r5931. See #3897. Fixes #5293.

#9 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.