Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 6 years ago

#5096 closed enhancement (maybelater)

Toolbar visibility should be more granular or not global

Reported by: ubernaut's profile ubernaut Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Toolbar & Notifications Keywords: needs-patch, trac-tidy-2018
Cc: ubernaut@…

Description

i noticed that this setting has global implications for multisite installs. This is a problem because if your theme is not coded with a login link you are forced to turn the visibility on for logged out users. This means that every site on your network will also show the toolbar for logged out visitors.

i would suggest that this setting should only effect the primary blog or there should be a secondary option defining this setting for the network of subsites.

Change History (5)

#1 @johnjamesjacoby
11 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Since BuddyPress tends to integrate pretty heavily with the Toolbar, we've kept it a simple always-on/always-off option, to provide a consistent feel to a network of sites.

  • You can always make a plugin for this, if it's something you need for a specific use case.
  • You can activate BuddyPress only on the sites you need it on, and leave it off for the ones you don't.
  • You can Multinetwork your install, and run BuddyPress only on the Network it belongs on.
  • A future solution, would be to only activate the components you need on some sites, and conditionally switch the constant based on an array of whitelisted sites.

I do agree, though, that we could do more with our Toolbar integration, and that some of that old code could be deprecated.

Moving to Future Release. If someone wants to patch this specific issue, feel free to bring it back to life.

#2 @ubernaut
11 years ago

  • Cc ubernaut@… added

So are we saying it's safe to assume that most if not all networks should have consistent UI/UX or appearance across all sites?

The more i think about this the more i think it actually is symptomatic of a larger issue/challenge with theme compatibility. The idea of a login/out/register button. For normal wordpress sites this function is not commonly needed but for buddypress sites it is fundamental. We are forcing any end user that does not have a theme that has been specifically coded for buddypress to either show the bar globally across the network or use the widget area for those buttons.

Not sure i have an idea of how this could be better done but i'll think about it and update the ticket with any further ideas i have.

#3 @DJPaul
8 years ago

  • Component changed from General - Toolbar/BuddyBar to Toolbar & Notifications

#4 @DJPaul
6 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#5 @DJPaul
6 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.