Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 6 years ago

#5092 closed enhancement (maybelater)

In Member's group invites list, hidden group permalink should be filtered to avoid 404

Reported by: imath's profile imath Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.8
Component: Groups Keywords: needs-testing, needs-refresh, trac-tidy-2018
Cc:

Description

If a member is invited to join an hidden group, in his pending invites screen, he will find a new group in his list with the buttons to accept or reject the invitation.
Problem is that the link in the title or the avatar of the group are clickable and as the user hasn't joined yet the group, if he clicks on it he's redirected to a 404.
I think we should avoid this 404, by filtering the group permalink in this case and warning him to join the group first to access it if he clicks on the link.
That's what i suggest in the attached diff.

Attachments (1)

5092.diff (7.1 KB) - added by imath 11 years ago.

Download all attachments as: .zip

Change History (8)

@imath
11 years ago

#1 @boonebgorges
11 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 1.9

I'm not convinced that this is the right kind of solution (at least not by itself). First, security/privacy issues should never be solved with JS alone, since it's so easy to turn off JS. Second, while it's true that hidden groups should not be visible to non-members, the very act of sending an invitation has exposed the existence of the group to the invitee (after all, its name appears on the list of invitations).

However, it is indeed a problem that clicking the link results in a 404. Maybe in cases where a user tries to access a hidden group of which he's not a member but to which he's received an invitation, we should load the group template, but show a "this group is hidden" message - like we already do for private groups. The logic would be here-ish (261): http://buddypress.trac.wordpress.org/browser/tags/1.7.2/bp-groups/bp-groups-loader.php#L254

#2 @boonebgorges
10 years ago

  • Milestone changed from 1.9 to 2.0

Since this is a fairly edge case, and a new patch needs to be written, I'm moving it to 2.0.

#3 @boonebgorges
10 years ago

  • Keywords has-patch removed
  • Milestone changed from 2.0 to 2.1

#4 @DJPaul
10 years ago

  • Milestone changed from 2.1 to Future Release

#5 @johnjamesjacoby
9 years ago

  • Version changed from 1.8-beta to 1.8

#6 @DJPaul
6 years ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#7 @DJPaul
6 years ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.