Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#5091 closed enhancement (fixed)

BP Default should also warn user about unsaved changes when leaving edit profile

Reported by: imath's profile imath Owned by: boonebgorges's profile boonebgorges
Milestone: 1.8 Priority: normal
Severity: normal Version: 1.8
Component: Templates Keywords: has-patch
Cc:

Description

In the buddypress.js of the bp-template dir, there's a new and very interesting feature that warns the user if he's about to leave the page and didn't save the change he made to his profile.

I've noticed, that BP Default doesn't have this feature. I think it would be interesting that users using this theme should also benefit this new feature. So i've simply copy-pasted the code from bp-template to bp-default in the attached diff.

Attachments (1)

5091.diff (1.6 KB) - added by imath 11 years ago.

Download all attachments as: .zip

Change History (6)

@imath
11 years ago

#1 @DJPaul
11 years ago

FWIW, this was introduced in r7151.

As far as I'm concerned, this should be a wontfix because we shouldn't spend time backporting *enhancements* to BP-Default, only bug fixes.

#2 @boonebgorges
11 years ago

  • Milestone changed from Awaiting Review to 1.8

As far as I'm concerned, this should be a wontfix because we shouldn't spend time backporting *enhancements* to BP-Default, only bug fixes.

I've gone back and forth about this during the current dev cycle (which explains why this specific enhancement wasn't added to bp-default, while others were). I think I've settled on the following position: For 1.8, let's continue with feature parity, since we haven't consciously decided otherwise. After 1.8, I'll propose that we announce publicly that bp-default will no longer receive enhancements. That way, there'll be a clear break point, and people who are very worried about it can transition away from bp-default during the 1.9 cycle.

#3 @boonebgorges
11 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7252:

Ports "Are you sure you want to leave page" dialog to bp-default.

Originally implemented in bp-legacy in r7151.

Fixes #5091

Props imath

#4 @johnjamesjacoby
9 years ago

  • Version changed from 1.8-beta to 1.8

#5 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.