#5091 closed enhancement (fixed)
BP Default should also warn user about unsaved changes when leaving edit profile
Reported by: | imath | Owned by: | boonebgorges |
---|---|---|---|
Milestone: | 1.8 | Priority: | normal |
Severity: | normal | Version: | 1.8 |
Component: | Templates | Keywords: | has-patch |
Cc: |
Description
In the buddypress.js of the bp-template dir, there's a new and very interesting feature that warns the user if he's about to leave the page and didn't save the change he made to his profile.
I've noticed, that BP Default doesn't have this feature. I think it would be interesting that users using this theme should also benefit this new feature. So i've simply copy-pasted the code from bp-template to bp-default in the attached diff.
Attachments (1)
Change History (6)
#2
@
11 years ago
- Milestone changed from Awaiting Review to 1.8
As far as I'm concerned, this should be a wontfix because we shouldn't spend time backporting *enhancements* to BP-Default, only bug fixes.
I've gone back and forth about this during the current dev cycle (which explains why this specific enhancement wasn't added to bp-default, while others were). I think I've settled on the following position: For 1.8, let's continue with feature parity, since we haven't consciously decided otherwise. After 1.8, I'll propose that we announce publicly that bp-default will no longer receive enhancements. That way, there'll be a clear break point, and people who are very worried about it can transition away from bp-default during the 1.9 cycle.
FWIW, this was introduced in r7151.
As far as I'm concerned, this should be a wontfix because we shouldn't spend time backporting *enhancements* to BP-Default, only bug fixes.