Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#5068 closed defect (bug) (fixed)

A Notice error is thrown if replying to an activity in Activity Administration

Reported by: imath's profile imath Owned by: boonebgorges's profile boonebgorges
Milestone: 1.9 Priority: low
Severity: minor Version: 1.8
Component: Activity Keywords: has-patch
Cc:

Description

In the administration of the activity, if i ajax reply to an activity, then it throws a notice error about the Undefined index: hook_suffix in /wp-admin/includes/screen.php at line 402. The problem seems to be that the screen argument is not defined in the construct method of BP_Activity_List_Table.

So i suggest the diff attached to this ticket which also strips the call to get_current_screen() in the prepare_items() function and replaces $screen->id by $this->screen->id in the $per_page var.

Attachments (1)

5068.diff (980 bytes) - added by imath 9 years ago.

Download all attachments as: .zip

Change History (4)

@imath
9 years ago

#1 @boonebgorges
9 years ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Awaiting Review to 1.9
  • Priority changed from normal to low

Looks good at a glance, but I'd like to wait until 1.9, as the current notice isn't hurting anything and I haven't dug deep enough into the root issues.

#2 @boonebgorges
9 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7473:

Avoid PHP notice when leaving activity comments in Activity Admin.

Fixes #5068

Props imath

#3 @johnjamesjacoby
8 years ago

  • Version changed from 1.8-beta to 1.8
Note: See TracTickets for help on using tickets.