If mentions are disabled @username may not show in member's header

[imath]

I've tested the new filter introduced in 1.8 to disable mentions, and while displaying a member's profile, i thought may be the mention @username in the member's header should not show as it's goal is to inform how to mention a user.
so just in case, i've attached the diff to disable this information in case the mentions are disabled.

[boonebgorges]

Good catch, imath.

I think that your patch is a bit more complex than what we really need. Burying the theme compat check inside of a template function seems wrong to me, especially since we're moving away from bp-default. And we generally prefer to avoid creating markup inside of functions if we can help it.

This is a case where the best solution is the simplest: putting bp_activity_do_mentions() checks right into the templates.

[boonebgorges]

In 7232:

Don't show @username in member headers if mentions are disabled

It's unnecessary and misleading to show this information when mentions have
been turned off.

Fixes #5067

Props imath for inital patch

[imath]

Replying to boonebgorges:

This is a case where the best solution is the simplest.

Hi Boone, thanks for your explanation and i completely agree :)