Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

#5023 closed defect (bug) (fixed)

BP_Activity_Activity class method get_sitewide_items_for_feed uses deprecated and deleted function bp_activity_get_sitewide

Reported by: ericlewis's profile ericlewis Owned by: boonebgorges's profile boonebgorges
Milestone: 1.8 Priority: normal
Severity: normal Version:
Component: Activity Keywords: needs-patch
Cc:

Description

This method seems to have been broken since r2168 when bp_activity_get_sitewide() was removed in lieu of bp_activity_get().

Attachments (2)

5023.diff​ (1.9 KB) - added by ericlewis 12 years ago.
reintroduce and deprecate bp_activity_get_sitewide(), rewriting a bit to use up-to-date activity API function
5023.1.diff​ (2.0 KB) - added by ericlewis 12 years ago.
add _deprecated_function call

Download all attachments as: .zip

Change History (4)

#1 @boonebgorges
12 years ago

  • Component changed from Core to Activity
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 1.8

Huh. It looks like BP doesn't use this method anywhere, which would explain why we have never caught it before.

Can you dig up bp_activity_get_sitewide() and see if it still works? If so, we can just properly deprecate it, and call it good enough. Otherwise the method will have to be rewritten to use our current functions.

@ericlewis
12 years ago

reintroduce and deprecate bp_activity_get_sitewide(), rewriting a bit to use up-to-date activity API function

@ericlewis
12 years ago

add _deprecated_function call

#2 @boonebgorges
12 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7201:

Properly deprecated deleted function bp_activity_get_sitewide()

Deleted in 1.2, this function was still called in
BP_Activity_Activity::get_sitewide_items_for_feed().

Fixes #5023

Props ericlewis

Note: See TracTickets for help on using tickets.