Admin authority not being respected for xprofile field visibility

[ubernaut]

so if the option "My Friends" is selected this setting overrides the admins ability to see it from the front end.

[boonebgorges]

Could you give more details? What is "admin authority"?

[ubernaut]

well admins should always be able to see any profile field regardless of the setting. it should not disallow me to see it because i'm not a friend.

[boonebgorges]

Thanks. I just didn't understand what the original report was about, but now I get it. Steps to reproduce (as I understand them):

• As a non-admin, set one of your profile fields to Friends Only
• As an admin, view the non-admin's profile

I haven't verified the bug report yet. Leaving in Awaiting Review until I or someone else has had a chance to run through it.

[ubernaut]

yup that's it exactly. i'll get the hang of these trac reports one of these days! :D

[ubernaut]

Replying to boonebgorges:

Thanks. I just didn't understand what the original report was about, but now I get it. Steps to reproduce (as I understand them):

• As a non-admin, set one of your profile fields to Friends Only
• As an admin, view the non-admin's profile

I haven't verified the bug report yet. Leaving in Awaiting Review until I or someone else has had a chance to run through it.

oh sorry one more thing probably obvious but just in case, i hadn't actually checked this but i'm thinking its safe to assume this only happens if the admin is not a friend.

[johnjamesjacoby]

Not able to duplicate this, regardless of the default visibility setting.

Closing as worksforme.

[ubernaut]

this is not related to the default setting it is related to the actually selected (unless it is the default) setting of "my friends" i have confirmed this on two separate installs. with that setting enabled you cannot even view the field if you are editing the profile. if it helps i could make a screen capture showing the problem.

[johnjamesjacoby]

• Single Site or Multisite?
• Are you a super admin or an admin?

[ubernaut]

both, first example is a real multisite (super admin), second is local install single site.

[ubernaut]

added a video to help illustrate the issue.

[johnjamesjacoby]

Replying to ubernaut:

added a video to help illustrate the issue.

Ah. So it's when the admin is editing the other person's profile, not when viewing it?

Still not able to duplicate here. Possible it's related to that weird user switching plugin you're using?

[ubernaut]

both actually and same results with only buddypress activated. it is sort of difficult to replicate without the user switching plugin since you have to log in and out so much but it's a great plugin, very handy for bp/multisite. happy to screenshare with you if you think that would help. I'm fairly certain this would happen on any install.

[johnjamesjacoby]

Replying to ubernaut:

both actually and same results with only buddypress activated. it is sort of difficult to replicate without the user switching plugin since you have to log in and out so much but it's a great plugin

Use separate Chrome users: ​https://support.google.com/chrome/answer/2364824?hl=en

happy to screenshare with you if you think that would help. I'm fairly certain this would happen on any install.

Add me on Skype, and I'll show you it working correctly on my local. 'johnjamesjacoby'

[ubernaut]

not on Skype but i just sent you an auth request on gtalk assuming the same handle.

[johnjamesjacoby]

Was able to duplicate now. The problem I had was the two accounts were already friends. Duh.

Working on a patch.

[ubernaut]

one in row rock on! thanks for your help and patience on this jjj!

[johnjamesjacoby]

Haven't had time to address this in detail, so moving to 1.8.1 so as not to delay 1.8.

[imath]

Hello,

Problem seemed to be that the array of hidden fields was partially set before bp_current_user_can('bp_moderate');

so regular user had array( 'friends', 'adminsonly') as expected
but admin got array('friends') instead of nothing, so in the patch i build the array of visibility after bp_current_user_can('bp_moderate') and it seems to solve the trouble.

in bp_xprofile_get_fields_by_visibility_level() i've also set $field_ids as an array as i've seen a notice.

[boonebgorges]

Thanks, imath. This logic looks pretty much correct. I'm going to make a more extensive fix, so that we can do better unit testing, and to make the bp_moderate stuff even clearer.

[boonebgorges]

In 7363:

Fix hidden xprofile fields for admins

XProfile field visibility was not being calculated correctly for admins,
due to incorrect logic in bp_xprofile_get_hidden_fields_for_user(). This
changeset clears up the logic, by moving the bp_moderate check earlier
in the flow.

To make the changes easier to implement and to test, this changeset also
breaks the calculation of visibility levels for a user-user pair into
a separate function, bp_xprofile_get_hidden_field_types_for_user().

Also introduces unit tests for the latter function.

Fixes #4984

Props imath

[boonebgorges]

In 7365:

Fix hidden xprofile fields for admins

XProfile field visibility was not being calculated correctly for admins,
due to incorrect logic in bp_xprofile_get_hidden_fields_for_user(). This
changeset clears up the logic, by moving the bp_moderate check earlier
in the flow.

To make the changes easier to implement and to test, this changeset also
breaks the calculation of visibility levels for a user-user pair into
a separate function, bp_xprofile_get_hidden_field_types_for_user().

Also introduces unit tests for the latter function.

Fixes #4984

Props imath

[johnjamesjacoby]

Milestone 1.8.2 deleted