Opened 12 years ago
Closed 10 years ago
#4972 closed defect (bug)
Purpose of bp_is_user_deleted()?
Reported by: | r-a-y | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 1.5.2 |
Component: | Members | Keywords: | |
Cc: | johnjamesjacoby |
Description
While auditing the bp_is_user_deleted()
function, I was wondering what the use-case is for this function.
Two other things:
1) https://buddypress.trac.wordpress.org/browser/tags/1.7.1/bp-members/bp-members-functions.php#L708
WP core doesn't use this flag anymore, but I'm guessing it's from the old WPMU days. I can't name an instance when this will ever be used. Perhaps in some really old plugins?
2) https://buddypress.trac.wordpress.org/browser/tags/1.7.1/bp-members/bp-members-functions.php#L711
BP uses this flag internally for accounts that haven't been activated yet.
But the function name is called bp_is_user_deleted()
. Shouldn't we move the user_status == 2
check into bp_is_user_active()
instead?
This is a port of bbPress 2's bbp_is_user_deleted() function, and without looking at the logs, I guess it was probably added to BP in the 1.5 release. It doesn't seem to be used much in bbPress either, so I'm assuming this was something that was built for one purpose, but then was replaced with something else.
Pinging @johnjamesjacoby