Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

#4862 closed defect (bug) (fixed)

Cancel link in activity comment replies not working properly

Reported by: dcrabill Owned by:
Milestone: 1.7 Priority: normal
Severity: normal Version: 1.7
Component: Activity Keywords:
Cc:

Description

The new cancel link doesn't work when the activity list has been refreshed with ajax.

To reproduce the problem, go to example.com/activity and click the "All Members" tab (or anything that will refresh the activity list). Then open the comment dialog and click "Cancel" -- the comment box shouldn't close and the page should jump to the top.

The cancel link works fine before any ajax calls.

Change History (2)

#1 @boonebgorges
9 years ago

  • Keywords needs-patch removed
  • Milestone changed from Awaiting Review to 1.7

Confirmed.

#2 @boonebgorges
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6838]) For activity comment Cancel link, use stream delegation

Delegation is necessary in this case, so that the Cancel button works for items
that are added to the DOM via AJAX, as when clicking different activity
filters.

Fixes #4862

Note: See TracTickets for help on using tickets.