Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#4861 closed defect (bug) (fixed)

Groups Admin UI : bulk delete trouble

Reported by: imath Owned by:
Milestone: 1.7 Priority: normal
Severity: normal Version: 1.7
Component: Groups Keywords: has-patch needs-testing
Cc:

Description

Hi,

I think there's several troubles in bulk actions (actually the delete one) in the Groups Admin UI.

1/ the first trouble is in case of bulk delete, the bp_groups_admin_index() is always fired causing weird behavior and notice errors.
As at line 80 of bp-groups-admin.php

$_REQUEST['action'] = $_REQUEST['action2']; 

then in the function bp_groups_admin() $doaction is never set to 'delete' but '-1' and the bp_groups_admin_delete() is not called.

2/ Once i've fixed trouble 1/, i've noticed that if more than one group are requested to be deleted, only the first one is deleted.

3/ Finally the admin notice message was saying '%s activity...' or '%s activity items...' instead of '%s group' or '%s groups'.

You'll find the patch i've used to solve the problem in the diff attached to this ticket.

Attachments (1)

4861.diff (2.0 KB) - added by imath 8 years ago.

Download all attachments as: .zip

Change History (6)

@imath
8 years ago

#1 @boonebgorges
8 years ago

(In [6830]) s/activity/group throughout bp-groups-admin.php

See #4861

Props imath

#2 @boonebgorges
8 years ago

(In [6832]) Introduces bp_admin_list_table_current_bulk_action() and applies to group and activity admin pages

WP_List_Table pages have top and bottom bulk action dropdowns: 'action' and
'action2'. This changeset reconciles these two dropdowns on form submit.

See #4861

Hat tip to imath for original patch

#3 @boonebgorges
8 years ago

  • Milestone changed from Awaiting Review to 1.7

#4 follow-up: @boonebgorges
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6835]) Fix bug preventing groups from being deleted in bulk

Also fixes redirect after group deletion

Fixes #4861

Hat tip to imath for original patch

#5 in reply to: ↑ 4 @imath
8 years ago

Replying to boonebgorges:

Hi Boone, it works great !! thanks for the hat tips :)

Note: See TracTickets for help on using tickets.