Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

#4856 closed enhancement (fixed)

Performance problem with bp_blogs_record_existing_blogs

Reported by: borkweb Owned by: boonebgorges
Milestone: 1.8 Priority: normal
Severity: normal Version:
Component: Blogs Keywords: has-patch
Cc:

Description

When querying users via get_users, all user fields are retrieved when only the ID is needed/used This is a performance hit with large collections of users. Adding the fields parameter would do nicely.

Attachments (1)

bp-blogs-functions.patch (695 bytes) - added by borkweb 7 years ago.

Download all attachments as: .zip

Change History (3)

#1 @boonebgorges
7 years ago

  • Milestone changed from Awaiting Review to 1.8

Good find.

#2 @boonebgorges
7 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 6930:

Don't query for entire user objects in bp_blogs_record_existing_blogs()

When recording existing blogs, we only need user ids of blog members. So it's
only necessary to query for the ID field when using get_users(). This should
result in significant performance enhancements on large installations.

Fixes #4856

Props borkweb

Note: See TracTickets for help on using tickets.