Changeset 6930

Timestamp:

04/19/2013 09:11:47 PM (13 years ago)

Author:

boonebgorges

Message:

Don't query for entire user objects in bp_blogs_record_existing_blogs()

When recording existing blogs, we only need user ids of blog members. So it's
only necessary to query for the ID field when using get_users(). This should
result in significant performance enhancements on large installations.

Fixes #4856

Props borkweb

File:

• trunk/bp-blogs/bp-blogs-functions.php (modified) (2 diffs)

trunk/bp-blogs/bp-blogs-functions.php

@@ -57 +57 @@
         if ( !empty( $blog_ids ) ) {
                 foreach( (array) $blog_ids as $blog_id ) {
-                        $users       = get_users( array( 'blog_id' => $blog_id ) );
-                        $subscribers = get_users( array( 'blog_id' => $blog_id, 'role' => 'subscriber' ) );
+                        $users       = get_users( array( 'blog_id' => $blog_id, 'fields' => 'ID' ) );
+                        $subscribers = get_users( array( 'blog_id' => $blog_id, 'fields' => 'ID', 'role' => 'subscriber' ) );
 
                         if ( !empty( $users ) ) {
@@ -64 +64 @@
                                         // Don't record blogs for subscribers
                                         if ( !in_array( $user, $subscribers ) ) {
-                                                bp_blogs_record_blog( $blog_id, $user->ID, true );
+                                                bp_blogs_record_blog( $blog_id, $user, true );
                                         }
                                 }