Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#4611 closed enhancement (fixed)

Cancel link for comment replies in activity stream

Reported by: jbobich's profile jbobich Owned by:
Milestone: 1.7 Priority: normal
Severity: minor Version: 1.7
Component: Templates Keywords: has-patch commit
Cc: jbobich

Description

In looking at the activity stream, I was thinking it might be more logical to have a "Cancel" link to cancel a comment reply instead of the "or press esc to cancel" text that's there now.

Pressing esc should still work to cancel the reply, but replacing that text with a Cancel link will make it slightly more intuitive and also tighten up the amount of text that the legacy theme is actually inserting there.

Attachments (1)

4611.patch​ (1.8 KB) - added by jbobich 12 years ago.

Download all attachments as: .zip

Change History (4)

@jbobich
12 years ago

#1 @johnjamesjacoby
12 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 1.7

Like this idea a lot. Simplifies the string, and seems pretty logical.

#2 @johnjamesjacoby
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6460]) bp-legacy:

  • In activity comments, change 'esc to cancel' to a link to click to cancel.
  • Changes to buddypress.js, buddypress.css, and activity/entry.php.
  • Props jbobich.
  • Fixes #4611.

#3 @DJPaul
8 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.