Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 21 months ago

#4580 closed enhancement (maybelater)

Refactoring messages autocomplete to use jQuery UI Autocomplete

Reported by: travel-junkie Owned by: travel-junkie
Milestone: Priority: normal
Severity: minor Version:
Component: Messages Keywords: needs-patch, trac-tidy-2018
Cc:

Description

BuddyPress uses an outdated version of autocomplete within the messages component. I was still using it as well in the current version of my events plugin, but have upgraded to using the jQuery UI Autocomplete version that ships with WordPress in the new version of it. BuddyPress should really do the same eventually.

I'd be happy to port what I have done over to BP and post it here as a patch for your perusal. Am fairly busy at the moment, though, so might only get to it in a month or so. If anybody else wants to have a go before me then I'd be happy to provide my JS code.

Styling-wise we could leave everything as is or spice it up. Not sure what's best here, but we would definitely need a new autocomplete style sheet. CSS isn't really my strong suite, so my patch would probably use Helen Housandi's styles as that's what I was using for my own rewrite.

Also, some plugins might be referencing the existing scripts for their own needs, even though they shouldn't really. Might be best to register them anyways for a given period and eventually chuck em out after making sure that everybody's educated about it.

~Boris

Change History (15)

#1 @travel-junkie
7 years ago

  • Owner set to travel-junkie
  • Status changed from new to assigned

#2 @DJPaul
7 years ago

jQuery UI is quite large, and I'm not convinced loading most of it to only use it for autocomplete is worthwhile. That said, I want to look at providing site-wide autocomplete for @ name-mentions (there's a ticket somewhere) for a future BP release, so perhaps we handle this and that at the same time.

#3 @boonebgorges
7 years ago

jQuery UI is quite large, and I'm not convinced loading most of it to only use it for autocomplete is worthwhile.

If we were concerned only with Messages autocomplete, the size of jQuery UI would not be an issue, because the Send Messages screen is so rarely accessed anyway.

In an ideal world, we would accomplish all sorts of autocomplete goodness with a single ticket, using the same base. But if that's going to take a long time (like, several versions), it's worth considering a refresh of Messages autocomplete in the meantime. (Though it's not urgent, because BP's autocomplete, while kludgy and hard to debug, is working fine at the moment, and I don't want to refactor for the sake of refactoring.)

travel-junkie, would you take a look at #3278 (and Paul's BP Labs plugin) to see how he's accomplishing this? Perhaps with a bit broader sense of how autocomplete will be adopted in a further version of BP, you might have a broader plan for implementation.

#4 @travel-junkie
7 years ago

Yup, sure. Will have a look at Pauls Ticket. Have also worked with BP Labs a while ago for a client and will check it out again. Where else is autocomplete being considered at the moment apart form @mentions?

The way I'd rewrite it would certainly be in a more general way with reusable functions so it could be easily adopted by other components.

I don't think that the size of UI is that much of an issue for a social network. It would be cached pretty fast, especially if it's being used in more components than just messages.

#5 @johnjamesjacoby
7 years ago

  • Milestone changed from Awaiting Review to 1.8

#6 @travel-junkie
7 years ago

I'm still up for doing this, but have been too busy. Hopefully, I'll get to it early 2013.

#7 @saurabhshukla
7 years ago

I've implemented jquery UI autocomplete for a custom plugin. I can take this up and complete it.

#8 @travel-junkie
7 years ago

Fine with me. Got busy with my start-up, so will still be a while until I could get to it.

#9 @boonebgorges
6 years ago

  • Milestone changed from 1.8 to Future Release
  • Resolution set to fixed
  • Status changed from assigned to closed

#10 @boonebgorges
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Oops, didn't mean to close.

#11 @slaFFik
5 years ago

  • Keywords close added

I believe this ticket can be closed, as we are using BuddyPress Suggestions API.

#12 @imath
4 years ago

  • Keywords needs-patch added; close removed
  • Milestone changed from Future Release to 2.6

@slaFFik Actually the messages component is still using these autocomplete scripts. So i suggest to work on it during 2.6.

#13 @DJPaul
3 years ago

  • Milestone changed from 2.6 to Future Release

#14 @DJPaul
21 months ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#15 @DJPaul
21 months ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.