Skip to:
Content

BuddyPress.org

Opened 8 years ago

Closed 5 years ago

#4567 closed defect (bug) (worksforme)

BuddyPress admin bar doesn't load avatar images over HTTPS if wp-admin site is HTTPS

Reported by: alexbilbie Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.6.1
Component: Core Keywords:
Cc: r-a-y, alexander.berthelsen@…

Description

If I am editing a post when the site is running over HTTPS then the avatar images in the BP admin bar aren't being loaded over HTTPS and so are causing mixed content warnings.

Change History (8)

#1 @DJPaul
8 years ago

  • Keywords reporter-feedback added

You say "avatar images", plural: where do we add multiple images to the admin bar? We do replace the image in the "howdy" menu when a user is logged in, but we only ever have one image there.

#2 @boonebgorges
8 years ago

  • Cc r-a-y added

We do swap out the admin bar image, and we do it using (eventually) wp_upload_dir(). From what I can see, wp_upload_dir() does *not* account for HTTPS. So my hunch is that alexbilbie is right, though I don't have an https rig to check on at the moment. I'm adding r-a-y as a watcher because I know he does.

#3 @r-a-y
8 years ago

alexbilbie: I have a couple of follow-up questions.

  • Do you have FORCE_SSL_ADMIN defined in wp-config.php?
  • For your avatar, did you upload an avatar or are you using Gravatar?
  • If you are using Gravatar, are you testing on a local site that is not accessible externally?

If you are locally-uploading an avatar and are using the FORCE_SSL_ADMIN define, your avatar image URL should switch over to HTTPS automatically.

If you have any other details about your install, let me know so I can try and duplicate it.

#4 @DJPaul
8 years ago

Ray: no feedback from original reporter in a month; do you want to bump this to future release because you suspect the issue might be valid, or shall we close it as invalid?

#5 @johnjamesjacoby
8 years ago

  • Milestone changed from Awaiting Review to 1.8

Going to punt to 1.8. Let's keep this alive and look into it more, but seems non urgent for 1.7, and we've all reviewed it.

#6 @boonebgorges
7 years ago

  • Milestone changed from 1.8 to Future Release

#7 @lakrisgubben
5 years ago

  • Cc alexander.berthelsen@… added

Tried this with WP 4.4.1 and BP trunk and I can't replicate, no mather if I use gravatar or locally uploaded profile photo or if I have the site_url and home_url set to https or http or if FORCE_SSL_ADMIN is true or false. i.e. it works as it should and I don't get any mixed content warnings. :)

#8 @r-a-y
5 years ago

  • Keywords reporter-feedback removed
  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Going to mark this as worksforme based off of @lakrisgubben's comments and older feedback.

Note: See TracTickets for help on using tickets.